D8333: fix some indenters from randomly invoking indent
mwolff closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 To: brauch, #ktexteditor, cullmann, dhaumann Cc: anthonyfieroni, #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D8333: fix some indenters from randomly invoking indent
cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for the fix! Just one thing: could we in addition have an addition indentation test that uses the trigger chars? Its amazing we seem to have none for this as otherwise this problem would have been fixed during the port. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 To: brauch, #ktexteditor, cullmann, dhaumann Cc: anthonyfieroni, #frameworks, kevinapavew, cullmann, sars, dhaumann
D8333: fix some indenters from randomly invoking indent
This revision was automatically updated to reflect the committed changes. Closed by commit R39:aeebeadb5f59: fix some indenters from indenting on random characters (authored by brauch). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8333?vs=20861=20874 REVISION DETAIL https://phabricator.kde.org/D8333 AFFECTED FILES src/script/kateindentscript.cpp To: brauch, #ktexteditor, cullmann, dhaumann Cc: anthonyfieroni, #frameworks, kevinapavew, cullmann, sars, dhaumann
D8333: fix some indenters from randomly invoking indent
brauch marked 2 inline comments as done. brauch added a comment. Yes, at least the ones I'm aware of. Thanks for the review, I'll push it in a moment. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 To: brauch, #ktexteditor, cullmann, dhaumann Cc: anthonyfieroni, #frameworks, kevinapavew, cullmann, sars, dhaumann
D8333: fix some indenters from randomly invoking indent
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. That makes a lot of sense. Please commit. Does that fix the indentation problems reported about Python? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 To: brauch, #ktexteditor, cullmann, dhaumann Cc: anthonyfieroni, #frameworks, kevinapavew, cullmann, sars, dhaumann
D8333: fix some indenters from randomly invoking indent
brauch marked an inline comment as done. brauch added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kateindentscript.cpp:47 > But if triggerCharacters are undefined this variable should be false, no? No, that's still fine, this variable just caches reading the value from the script object. If the script doesn't define it, it is read as empty, and then doesn't look again (because that won't change in the future). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 To: brauch, #ktexteditor, cullmann, dhaumann Cc: anthonyfieroni, #frameworks, kevinapavew, cullmann, sars, dhaumann
D8333: fix some indenters from randomly invoking indent
anthonyfieroni added inline comments. INLINE COMMENTS > kateindentscript.cpp:47 > > m_triggerCharactersSet = true; > But if triggerCharacters are undefined this variable should be false, no? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 To: brauch, #ktexteditor, cullmann, dhaumann Cc: anthonyfieroni, #frameworks, kevinapavew, cullmann, sars, dhaumann
D8333: fix some indenters from randomly invoking indent
brauch created this revision. brauch added reviewers: KTextEditor, cullmann, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY If triggerCharacters was not set, toString() would return "undefined", making indenters trigger on u, n, d, e, f, i and n. TEST PLAN Trigger chars are still set correctly for e.g. cmake. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 AFFECTED FILES src/script/kateindentscript.cpp To: brauch, #ktexteditor, cullmann, dhaumann Cc: #frameworks, kevinapavew, cullmann, sars, dhaumann
