D8348: Add a section for removable devices

2017-11-26 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3db04cfc5179: Add a section for removable devices 
(authored by Renato Araujo Oliveira Filho renato.ara...@kdab.com, 
committed by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=22949=22960

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-26 Thread Renato Oliveira Filho 
renatoo added a comment.


  In https://phabricator.kde.org/D8348#172032, @ngraham wrote:
  
  > @renatoo, now that https://phabricator.kde.org/D8332 is in, this no patch 
longer applies cleanly. Can you update so I can land it?
  
  
  I updated it. Could you try again.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-26 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 22949.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=22811=22949

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-25 Thread Nathaniel Graham 
ngraham added a comment.


  @renatoo, now that https://phabricator.kde.org/D8332 is in, this no patch 
longer applies cleanly. Can you update so I can land it?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-23 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 22811.
renatoo added a comment.


  Parent branch updated

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=22776=22811

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-22 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 22776.
renatoo added a comment.


  Updated from master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=22764=22776

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-22 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 22764.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=22453=22764

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-22 Thread Renato Oliveira Filho 
renatoo added a dependent revision: D8943: Create 
'KFilePlacesModel::convertedUrl' static function.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-17 Thread Renato Oliveira Filho 
renatoo added a dependent revision: D8862: Extend API.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-16 Thread Renato Oliveira Filho 
renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source 
model for PlacesItemModel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-16 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 22453.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=22393=22453

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-15 Thread Milian Wolff 
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  lgtm too

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-15 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  In https://phabricator.kde.org/D8348#167982, @renatoo wrote:
  
  > This is not related with the change. I am working on that in a different 
branch.
  
  
  OK, thanks! Please add me to the review list for that patch, once it's up.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-15 Thread Renato Oliveira Filho 
renatoo added inline comments.

INLINE COMMENTS

> mwolff wrote in kfileplacesitem.cpp:91
> shouldn't this always be called? i.e. when the bookmark is changed to a 
> different UDI, don't we need to update here, even when we had a valid device 
> UDI before? I think this also means this path isn't unit tested yet

Changed the code to always check for udi changes. 
I tried to implement a unit test for this case, but I could not find a way to 
simulate it, and manual updating the bookmark udi cases the model to create a 
new item since uid is used as id for the model items.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-15 Thread Renato Oliveira Filho 
renatoo marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-15 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 22393.
renatoo added a comment.


  Update device info if udi changes.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=22329=22393

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-15 Thread Renato Oliveira Filho 
renatoo marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-15 Thread Renato Oliveira Filho 
renatoo added a comment.


  In https://phabricator.kde.org/D8348#167924, @mwolff wrote:
  
  > In https://phabricator.kde.org/D8348#163546, @ngraham wrote:
  >
  > > Could you add camera:/ devices to this section too? That way we could 
also take care of https://bugs.kde.org/show_bug.cgi?id=386060
  >
  >
  > this isn't done yet, I think
  
  
  This is not related with the change. I am working on that in a different 
branch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-15 Thread Milian Wolff 
mwolff added inline comments.

INLINE COMMENTS

> mwolff wrote in kfileplacesmodeltest.cpp:181
> the changed list of remote urls that is repeated below could be put into 
> another helper function

done already in https://phabricator.kde.org/D8366 I see, ignore this

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-15 Thread Milian Wolff 
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  the UDI comment needs to be investigated, otherwise lgtm

INLINE COMMENTS

> kfileplacesmodeltest.cpp:181
>  return QStringList() << QDir::homePath() << QStringLiteral("remote:/") 
> << QStringLiteral(KDE_ROOT_PATH) << QStringLiteral("trash:/")
> - << QStringLiteral("/media/nfs") << 
> QStringLiteral("/media/floppy0") << QStringLiteral("/media/XO-Y4") << 
> QStringLiteral("/media/cdrom") << QStringLiteral("/foreign");
> + << QStringLiteral("/media/nfs") << 
> QStringLiteral("/foreign")
> + << QStringLiteral("/media/floppy0")  << 
> QStringLiteral("/media/XO-Y4") << QStringLiteral("/media/cdrom");

the changed list of remote urls that is repeated below could be put into 
another helper function

> kfileplacesitem.cpp:91
> +if (m_device.udi().isEmpty()) {
> +updateDeviceInfo(m_bookmark.metaDataItem(QStringLiteral("UDI")));
> +}

shouldn't this always be called? i.e. when the bookmark is changed to a 
different UDI, don't we need to update here, even when we had a valid device 
UDI before? I think this also means this path isn't unit tested yet

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-15 Thread Milian Wolff 
mwolff added a comment.


  In https://phabricator.kde.org/D8348#163546, @ngraham wrote:
  
  > Could you add camera:/ devices to this section too? That way we could also 
take care of https://bugs.kde.org/show_bug.cgi?id=386060
  
  
  this isn't done yet, I think

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-15 Thread Milian Wolff 
mwolff added a comment.


  In https://phabricator.kde.org/D8348#164718, @ngraham wrote:
  
  > In https://phabricator.kde.org/D8348#164713, @abetts wrote:
  >
  > > What about something like this as well
  > >
  > > F548: Unmount.png 
  > >
  > > The removable device gets an "unmount" or "disconnect" icon on hover?
  > >
  > > Thoughts?
  >
  >
  > Yes yes yes! That would also resolve 
https://bugs.kde.org/show_bug.cgi?id=154499
  >
  > Of course, if this isn't an easy change, we may not want to overload the 
patch.
  
  
  This should be done in a follow-up patch

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-14 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 22329.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=21933=22329

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham
Cc: abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-05 Thread Nathaniel Graham 
ngraham added a comment.


  In https://phabricator.kde.org/D8348#164713, @abetts wrote:
  
  > What about something like this as well
  >
  > F548: Unmount.png 
  >
  > The removable device gets an "unmount" or "disconnect" icon on hover?
  >
  > Thoughts?
  
  
  Yes yes yes! That would also resolve 
https://bugs.kde.org/show_bug.cgi?id=154499
  
  Of course, if this isn't an easy change, we may not want to overload the 
patch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham
Cc: abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-05 Thread Andres Betts 
abetts added a comment.


  What about something like this as well
  
  F548: Unmount.png 
  
  The removable device gets an "unmount" or "disconnect" icon on hover?
  
  Thoughts?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham
Cc: abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-05 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 21933.
renatoo added a comment.


  Parent branch update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=21808=21933

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-02 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 21808.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=21759=21808

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-02 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Could you add camera:/ devices to this section too? That way we could also 
take care of https://bugs.kde.org/show_bug.cgi?id=386060

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-02 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 21759.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=21648=21759

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-11-01 Thread Renato Oliveira Filho 
renatoo added a dependent revision: D8434: Created 'remote' section.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-31 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 21648.
renatoo added a comment.


  Update parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=21622=21648

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-31 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 21622.
renatoo added a comment.


  Use plural form for RemovableDevicesType enum

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=21584=21622

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-31 Thread Kevin Ottens 
ervin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-31 Thread Renato Oliveira Filho 
renatoo marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-31 Thread Kevin Ottens 
ervin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-31 Thread Kevin Ottens 
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Found a small one after all.

INLINE COMMENTS

> kfileplacesitem_p.h:51
> +DevicesType = 3,
> +RemovableDeviceType = 4
>  };

RemovableDevicesType (since you used the plural on the one above).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-31 Thread Laurent Montel 
mlaurent added a reviewer: ervin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-30 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 21584.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=21296=21584

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-30 Thread Laurent Montel 
mlaurent added a dependent revision: D8367: Hidding place groups implementation 
in KFilePlacesModel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-25 Thread Renato Oliveira Filho 
renatoo marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-25 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 21296.
renatoo added a comment.


  Used new connect API

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=21228=21296

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-25 Thread Laurent Montel 
mlaurent added inline comments.

INLINE COMMENTS

> kfileplacesitem.cpp:354
> +if (m_access) {
> +connect(m_access, SIGNAL(accessibilityChanged(bool,QString)),
> +this, SLOT(onAccessibilityChanged(bool)));

could you use new connect api please ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-24 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 21228.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=21003=21228

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg
Cc: anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-20 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 21003.
renatoo added a comment.


  Fixed unit test

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=20987=21003

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg
Cc: anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-19 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 20987.
renatoo marked 2 inline comments as done.
renatoo added a comment.


  Fixed code style

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=20953=20987

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg
Cc: anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-18 Thread Anthony Fieroni 
anthonyfieroni added inline comments.

INLINE COMMENTS

> kfileplacesitem.cpp:90
>  
> +if (m_device.udi().isEmpty())
> +updateDeviceInfo(m_bookmark.metaDataItem(QStringLiteral("UDI")));

Braces even on one line block.

> kfileplacesitem.cpp:328
> +{
> +if (m_device.udi() != udi) {
> +if (m_access) {

Early exit to not add unwanted indent.

  if (m_device.udi() == udi) {
  return false;
  }
  `

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg
Cc: anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-18 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 20953.
renatoo added a comment.


  Update parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=20941=20953

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg
Cc: ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-18 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 20941.
renatoo edited the summary of this revision.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=20919=20941

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg
Cc: ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-17 Thread Renato Oliveira Filho 
renatoo added a comment.


  In https://phabricator.kde.org/D8348#156659, @ngraham wrote:
  
  > Can you put the screenshot in the Summary section above, and list the 
dependencies there too? Also put dependency information there, in the following 
form:
  >
  >
  >  Depends on D8243
  >  Depends on D8332
  >
  >
  > This special syntax marks them as dependencies.
  
  
  Done, Thanks for the information.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg
Cc: ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-17 Thread Kai Uwe Broulik 
broulik added a reviewer: VDG.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg
Cc: ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-17 Thread Renato Oliveira Filho 
renatoo edited the summary of this revision.
renatoo added dependencies: D8243: Implement support for categories on 
KfilesPlacesView, D8332: Added baloo urls into places model.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks
Cc: ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-17 Thread Renato Oliveira Filho 
renatoo edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks
Cc: ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-17 Thread Nathaniel Graham 
ngraham added a comment.


  Can you put the screenshot in the Summary section above, and list the 
dependencies there too? Also put dependency information there, in the following 
form:
  
  
  Depends on D8243
  Depends on D8332
  
  
  This special syntax marks them as dependencies.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks
Cc: ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-17 Thread Renato Oliveira Filho 
renatoo added a comment.


  In https://phabricator.kde.org/D8348#156653, @ngraham wrote:
  
  > Is there a bugzilla ticket tracking this? And can you include a screenshot 
showing what it looks like now?
  
  
  There is no bugzilla, I can create one if that will helps.
  
  A preview can be find here: https://imgur.com/a/Vcb2v
  
  This patch depends on:
  
  - https://phabricator.kde.org/D8243
  - https://phabricator.kde.org/D8332

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks
Cc: ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-17 Thread Nathaniel Graham 
ngraham added a comment.


  Is there a bugzilla ticket tracking this? And can you include a screenshot 
showing what it looks like now?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks
Cc: ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-17 Thread Renato Oliveira Filho 
renatoo added reviewers: Dolphin, Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks
Cc: #frameworks

D8348: Add a section for removable devices

2017-10-17 Thread Renato Oliveira Filho 
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Show removable devices in a different section

TEST PLAN
  From any kde app try to open/save a file.
  Plug any removable device in your computer, make sure that it appears over 
'Removable devices' section on places panel

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo
Cc: #frameworks