This revision was automatically updated to reflect the committed changes.
Closed by commit R289:f2f65dee2962: do not make the context menu a Window
(authored by mkoller).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8519?vs=21431=23999
REVISION
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D8519
To: mkoller, davidedmundson, graesslin
Cc: #frameworks
mkoller added a comment.
Ping!
Anything wrong with this 2 liner patch ?
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D8519
To: mkoller, davidedmundson, graesslin
Cc: #frameworks
mkoller retitled this revision from "do not make the context menu a Window; do
not force raise a window" to "do not make the context menu a Window".
mkoller edited the summary of this revision.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D8519
To: mkoller,
graesslin added a comment.
Maybe we can drop the force activate for all hosts? Are there any
implementations left which are on X11? At least Ubuntu is Wayland based.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D8519
To: mkoller, davidedmundson, graesslin
davidedmundson added a comment.
Ah, I 1000% agree it /should/ work like that.
My very first comment on here ended with:
> In an ideal world the original SNI spec would have passed a timestamp...
So bringing discussion back to this patch.
- We need
graesslin added a comment.
In https://phabricator.kde.org/D8519#160909, @davidedmundson wrote:
> In https://phabricator.kde.org/D8519#160879, @graesslin wrote:
>
> > Actually even on X it is quite simple to get it right. We have the window
Id, so the host needs to update the xTime in
davidedmundson added a comment.
In https://phabricator.kde.org/D8519#160879, @graesslin wrote:
> Actually even on X it is quite simple to get it right. We have the window
Id, so the host needs to update the xTime in the window. The only question is
whether Qt reads it back. With an up
graesslin added a comment.
Actually even on X it is quite simple to get it right. We have the window Id,
so the host needs to update the xTime in the window. The only question is
whether Qt reads it back. With an up to date xTime a simple activate without a
force should work.
REPOSITORY
graesslin added a comment.
In https://phabricator.kde.org/D8519#160813, @davidedmundson wrote:
> > The removal of the force activation is done since according to kwin
maintainer it is wrong and must be done by the SysTray itself.
>
> But according the the status notifier item
mkoller updated this revision to Diff 21431.
mkoller added a comment.
In https://phabricator.kde.org/D8519#160813, @davidedmundson wrote:
> > The removal of the force activation is done since according to kwin
maintainer it is wrong and must be done by the SysTray itself.
>
> But
davidedmundson added inline comments.
INLINE COMMENTS
> kstatusnotifieritem.cpp:453
> d->menu = menu;
> -d->menu->setParent(nullptr);
> +//d->menu->setParent(nullptr);
> }
make setContextMenu safe against null pointers, prevents creating a dbus menu
exporter when we don't care
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
> The removal of the force activation is done since according to kwin
maintainer it is wrong and must be done by the SysTray itself.
But according the the
mkoller created this revision.
mkoller added reviewers: davidedmundson, graesslin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The setParent() call in this patch was changing the window flags from Popup
to Window,
14 matches
Mail list logo
