This revision was automatically updated to reflect the committed changes.
Closed by commit R824:16e77619ee73: Display Downloaded From by
default, if file supports it (authored by ngraham).
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
markg accepted this revision.
markg added a comment.
Lovely! Less code, more features, those are the cool changes :)
I think it's safe to push.
REPOSITORY
R824 Baloo Widgets
BRANCH
origin_url_386261
REVISION DETAIL
https://phabricator.kde.org/D8527
To: ngraham, #dolphin,
ngraham added a comment.
Do any Dolphin people object? If not, I'll land this in a few days (sooner if
I get some more thumbs up :) ).
REPOSITORY
R824 Baloo Widgets
BRANCH
origin_url_386261
REVISION DETAIL
https://phabricator.kde.org/D8527
To: ngraham, #dolphin, #frameworks,
vhanda accepted this revision.
vhanda added a comment.
This revision is now accepted and ready to land.
Looks good.
Maybe we should wait and see if someone who works on Dolphin has an opinion.
This widget is only used in Dolphin.
REPOSITORY
R824 Baloo Widgets
BRANCH
ngraham edited the summary of this revision.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D8527
To: ngraham, #dolphin, #frameworks, broulik, dfaure, markg
Cc: spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp
ngraham added reviewers: broulik, dfaure, markg.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D8527
To: ngraham, #dolphin, #frameworks, broulik, dfaure, markg
Cc: spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp
ngraham edited the test plan for this revision.
ngraham added reviewers: Dolphin, Frameworks.
ngraham added a project: Dolphin.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D8527
To: ngraham, #dolphin, #frameworks
Cc: spoorun, navarromorales, firef, ngraham,