This revision was automatically updated to reflect the committed changes.
Closed by commit R293:2e80367435cc: Consider DjVu files to be documents
(authored by ngraham).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8528?vs=21461=21597#toc
REPOSITORY
R293 Baloo
CHANGES SINCE LAST
rkflx accepted this revision.
rkflx added a comment.
This revision is now accepted and ready to land.
I'd say this can land. Perhaps best to wait until Monday evening, so
Frameworks people not spending their weekend at the computer have a chance to
weigh in?
REPOSITORY
R293 Baloo
BRANCH
vhanda added a comment.
Since I was added as a reviewer, I thought I'll comment.
I am not currently maintaining Baloo or using it, so I don't want to really
discuss the specifics. Though from a technical point of view this change will
work. If nobody has any objections, I would say go
ngraham added a reviewer: rkflx.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8528
To: ngraham, vhanda, #frameworks, rkflx
Cc: rkflx, #frameworks
ngraham marked 4 inline comments as done.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8528
To: ngraham, vhanda, #frameworks
Cc: rkflx, #frameworks
ngraham updated this revision to Diff 21461.
ngraham added a comment.
Only mark multipage DjVu files as documents, and remove crufty old
compatibility mimetype that's probably not relevant at all
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
rkflx added inline comments.
INLINE COMMENTS
> rkflx wrote in basicindexingjob.cpp:219
> Looking at `/usr/share/mime/image`, I see:
>
> - `vnd.djvu.xml`: "DjVu image"
> - `vnd.djvu+multipage.xml`: "DjVu document"
>
> …and that's also what Dolphin shows. Probably best to add `+multipage` here?
ngraham edited the test plan for this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8528
To: ngraham, vhanda, #frameworks
Cc: rkflx, #frameworks
ngraham updated this revision to Diff 21459.
ngraham marked an inline comment as done.
ngraham added a comment.
Actually we don't need the xml extension here
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8528?vs=21458=21459
BRANCH
ngraham added inline comments.
INLINE COMMENTS
> rkflx wrote in basicindexingjob.cpp:220
> Is `x-djvu` a thing? Not sure, that's why I'm asking.
https://www.cuminas.jp/docs/djvuplugin/en_us/Content/MIME%20Types.htm said that
it was an older one, so I figured I'd add that one for maximum
ngraham updated this revision to Diff 21458.
ngraham added a comment.
Adjusting MIME types to match what's in /usr/share/mime/images
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8528?vs=21455=21458
BRANCH
djvu_files_documents_369195
REVISION DETAIL
rkflx added a comment.
General sentiment makes sense, most DjVu documents I've seen were more like
books. However, see inline comment. (Someone with actual mimetype or baloo
knowledge should approve, though.)
> didn't crash baloo with basic usage
If you don't have a DjVu file,
ngraham edited the summary of this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8528
To: ngraham, vhanda, #frameworks
Cc: #frameworks
ngraham added reviewers: vhanda, Frameworks.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8528
To: ngraham, vhanda, #frameworks
Cc: #frameworks
ngraham created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
BUG: 369195
TEST PLAN
Tested in KDE Neon. Compiled and deployed fine; didn't crash baloo with basic
usage. Unable to test beyond that
15 matches
Mail list logo
