This revision was automatically updated to reflect the committed changes.
Closed by commit R280:2e2664b0ab0a: Add Aztec code generator (authored by
vkrause).
REPOSITORY
R280 Prison
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8546?vs=22559=22969
REVISION DETAIL
svuorela accepted this revision.
REPOSITORY
R280 Prison
REVISION DETAIL
https://phabricator.kde.org/D8546
To: vkrause, #frameworks, svuorela, dfaure
Cc: dfaure, #frameworks
vkrause updated this revision to Diff 22559.
vkrause added a comment.
Separate test images into those containing only rendering/layouting data and
those with full data encoding.
REPOSITORY
R280 Prison
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8546?vs=22205=22559
BRANCH
svuorela accepted this revision.
svuorela added a comment.
I like it. Though I haven't fully reviewed the bit magic and actually tested
it, but the first can be fixed at a later point, and the latter I trust you on.
INLINE COMMENTS
> vkrause wrote in aztec-compact-data-0011.png:1
> There
vkrause updated this revision to Diff 22205.
vkrause added a comment.
Fix off-by-one inconsistency in layerCount
It now always means the amount of layers and not the index of the last layer.
Fixes rendering of the unusually short Air Baltic boarding pass data.
REPOSITORY
vkrause updated this revision to Diff 22188.
vkrause added a comment.
Adapt to review comments.
REPOSITORY
R280 Prison
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8546?vs=21526=22188
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8546
AFFECTED FILES
vkrause added inline comments.
INLINE COMMENTS
> svuorela wrote in aztec-compact-data-0011.png:1
> For all these images, are this the only valid encoding for the relevant data,
> or are there enough extra data in aztec codes that a valid set of data can be
> encoded in multiple ways ?
There
svuorela added a comment.
Thanks for this contribution. I think it is good and needed.
INLINE COMMENTS
> CMakeLists.txt:1
> +set(aztecbarcodetest_srcs
> +aztecbarcodetest.cpp
I'd like an extra level of directories given the large amount of test files, so
we have e.g. autotests/aztec/
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:20
> +target_link_libraries(prison-reedsolomontest Qt5::Test KF5::Prison)
> +add_test(NAME prison-reedsolomontest COMMAND
lbeltrame added reviewers: Frameworks, svuorela.
REPOSITORY
R280 Prison
REVISION DETAIL
https://phabricator.kde.org/D8546
To: vkrause, #frameworks, svuorela
Cc: #frameworks
vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Needed e.g. for boarding pass rendering in https://phabricator.kde.org/D8395.
REPOSITORY
R280 Prison
BRANCH
master
REVISION DETAIL
11 matches
Mail list logo
