D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-09-08 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 41225.
kossebau added a comment.


  Reaching review candidate state, please start reviewing the code.
  
  Target is Frameworks 5.52, so the one after the upcoming Frameworks version.
  The current planned consumer of the new API is KDevelop 5.4, which may be
  branched end of year or next year, so nothing urgent to push and giving this
  another month of API reconsiderations is fine.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8708?vs=41112=41225

BRANCH
  addAnnotationItemDelegate

REVISION DETAIL
  https://phabricator.kde.org/D8708

AFFECTED FILES
  src/CMakeLists.txt
  src/include/CMakeLists.txt
  src/include/ktexteditor/abstractannotationitemdelegate.h
  src/include/ktexteditor/annotationinterface.h
  src/view/kateannotationitemdelegate.cpp
  src/view/kateannotationitemdelegate.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.h

To: kossebau
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-09-06 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 41112.
kossebau added a comment.


  fix not listening to sizeHintChanged signal

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8708?vs=41078=41112

BRANCH
  addAnnotationItemDelegate

REVISION DETAIL
  https://phabricator.kde.org/D8708

AFFECTED FILES
  src/CMakeLists.txt
  src/include/CMakeLists.txt
  src/include/ktexteditor/abstractannotationitemdelegate.h
  src/include/ktexteditor/annotationinterface.h
  src/view/kateannotationitemdelegate.cpp
  src/view/kateannotationitemdelegate.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.h

To: kossebau
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-09-05 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 41078.
kossebau added a comment.


  Dump update with some more changes (still TODOs left to handle)

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8708?vs=40990=41078

BRANCH
  addAnnotationItemDelegate

REVISION DETAIL
  https://phabricator.kde.org/D8708

AFFECTED FILES
  src/CMakeLists.txt
  src/include/CMakeLists.txt
  src/include/ktexteditor/abstractannotationitemdelegate.h
  src/include/ktexteditor/annotationinterface.h
  src/view/kateannotationitemdelegate.cpp
  src/view/kateannotationitemdelegate.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.h

To: kossebau
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-09-04 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 40990.
kossebau added a comment.
Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: 
Frameworks.


  update to latest master

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8708?vs=9=40990

BRANCH
  addAnnotationItemDelegate

REVISION DETAIL
  https://phabricator.kde.org/D8708

AFFECTED FILES
  src/CMakeLists.txt
  src/include/CMakeLists.txt
  src/include/ktexteditor/abstractannotationitemdelegate.h
  src/include/ktexteditor/annotationinterface.h
  src/view/kateannotationitemdelegate.cpp
  src/view/kateannotationitemdelegate.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.h

To: kossebau
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann, #frameworks


D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

2017-11-12 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 9.
kossebau added a comment.


  Update: add some API dox, more API fine-tuning

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8708?vs=22055=9

BRANCH
  addAnnotationItemDelegate

REVISION DETAIL
  https://phabricator.kde.org/D8708

AFFECTED FILES
  src/CMakeLists.txt
  src/include/CMakeLists.txt
  src/include/ktexteditor/abstractannotationitemdelegate.h
  src/include/ktexteditor/annotationinterface.h
  src/view/kateannotationitemdelegate.cpp
  src/view/kateannotationitemdelegate.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.h

To: kossebau
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann


D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

2017-11-07 Thread Friedrich W . H . Kossebau
kossebau added a comment.


  Example for custom rendering in KDevelop as currently proposed with the 
matching KDevelop patch https://phabricator.kde.org/D8709:
  F5481057: Screenshot_20171108_013745.png 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8708

To: kossebau
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann


D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

2017-11-07 Thread Friedrich W . H . Kossebau
kossebau added a dependent revision: D8709: [WIP] Add 
VcsAnnotationItemDelegate, for control of rendering, menus and tooltip.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8708

To: kossebau
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann


D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

2017-11-07 Thread Friedrich W . H . Kossebau
kossebau created this revision.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  The AbstractAnnotationItemDelegate is modelled after QAbstractItemDelegate
  and should allow consumers of the annotation interfaces to customize the
  rendering, the context menu and the tooltip per annotation as wanted.
  
  Yet to be solved:
  
  - whether, and if how, to adapt to zoomed content
  - which UI font to recommend if not wanting to use content font
  - tooltip hiding API (and perhaps support for async shown tooltips)
  
  and some other TODOs spread over the patch
  
  Done together with some new patches for KDevelop.

REPOSITORY
  R39 KTextEditor

BRANCH
  addAnnotationItemDelegate

REVISION DETAIL
  https://phabricator.kde.org/D8708

AFFECTED FILES
  src/CMakeLists.txt
  src/include/CMakeLists.txt
  src/include/ktexteditor/abstractannotationitemdelegate.h
  src/include/ktexteditor/annotationinterface.h
  src/view/kateannotationitemdelegate.cpp
  src/view/kateannotationitemdelegate.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.h

To: kossebau
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann