D8732: Fix race that starts kactivitymanagerd multiple times

2017-11-23 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R6:b4bdd796079c: Fix race that starts kactivitymanagerd 
multiple times (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8732?vs=22112=22819#toc

REPOSITORY
  R6 KActivities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8732?vs=22112=22819

REVISION DETAIL
  https://phabricator.kde.org/D8732

AFFECTED FILES
  src/lib/manager_p.cpp

To: davidedmundson, apol
Cc: apol, #frameworks

D8732: Fix race that starts kactivitymanagerd multiple times

2017-11-20 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R6 KActivities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8732

To: davidedmundson, apol
Cc: apol, #frameworks

D8732: Fix race that starts kactivitymanagerd multiple times

2017-11-09 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1 I can see the same issue in my bootchart.

INLINE COMMENTS

> manager_p.cpp:82
> +if (!reply.isValid()) {
> +//pre 5.12 the daemon did not support DBus 
> activation.  Fall back to manually forking
> +
> QProcess::startDetached(QStringLiteral("kactivitymanagerd"));

pre Plasma 5.12

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D8732

To: davidedmundson
Cc: apol, #frameworks

D8732: Fix race that starts kactivitymanagerd multiple times

2017-11-09 Thread David Edmundson 
davidedmundson added a dependency: D8733: DBus activate KActivityManagerd.

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D8732

To: davidedmundson
Cc: #frameworks

D8732: Fix race that starts kactivitymanagerd multiple times

2017-11-09 Thread David Edmundson 
davidedmundson added a comment.


  bootchart screenshot of the problem (courtesy of apol)
  
  F5483212: Spectacle.GxYIDa.png 

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D8732

To: davidedmundson
Cc: #frameworks

D8732: Fix race that starts kactivitymanagerd multiple times

2017-11-09 Thread David Edmundson 
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  During plasma startup we have multiple processes using kactivities at
  once. The current code looks to see if the bus is active then launched
  the executable.
  
  If this happens at once, we end up loading, doing all the
  initialisation only for all-but-one of the services to fail to register the 
name
  and then quit.
  
  By using DBus activation, we get that global lock in a very safe way.
  
  This requires a change (a .service file) on the daemon, so a fallback is
  provided for 5.11 support

TEST PLAN
  Had just this change.
  Killed kactivitymanagerd
  Restarted plasmashell. It launched
  Made workspace change. Had activities.

REPOSITORY
  R6 KActivities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8732

AFFECTED FILES
  src/lib/manager_p.cpp

To: davidedmundson
Cc: #frameworks