D8773: Improve discoverability of drag-and-drop of toolbar actions

ngraham added a comment. Haha yes almost exactly like that! Maybe today I'd use a sheet instead of a separate dialog window. But I have great faith that the 2019 David is able to conquer the challenges of 2009. :) REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773

D8773: Improve discoverability of drag-and-drop of toolbar actions

davidedmundson added a comment. > That is excellent! That was from my very first PlanetKDE blog post back in 2009 :D And from what I recall, I hit that exact issue you're describing and gave up. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvis

D8773: Improve discoverability of drag-and-drop of toolbar actions

dfaure added a comment. That is excellent! But in the implementation, mind the "multiple kxmlgui-clients" use case, like konqueror or kdevelop (or kate I guess). It can make things tricky... (you drop between two clients, how do you know which one should memorize the action into its kxmlgu

D8773: Improve discoverability of drag-and-drop of toolbar actions

davidedmundson added a comment. @ngraham Like this: http://static.davidedmundson.co.uk/toolbars_change_01.ogv ? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvisangelaccio, #frameworks, #vdg, dfaure, ngraham Cc: davidedmundson, kde-frameworks-devel, b

D8773: Improve discoverability of drag-and-drop of toolbar actions

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Herald added a subscriber: kde-frameworks-devel. In D8773#167625 , @colomar wrote: > In D8773#167607

D8773: Improve discoverability of drag-and-drop of toolbar actions

colomar added a comment. In https://phabricator.kde.org/D8773#167607, @broulik wrote: > What I would like to see is that when you open the "Edit Toolbar" dialog that you then can drag around tool bar buttons and drag them from and to the dialog, like Firefox does it and how @colomar sugg

D8773: Improve discoverability of drag-and-drop of toolbar actions

broulik added a comment. What I would like to see is that when you open the "Edit Toolbar" dialog that you then can drag around tool bar buttons and drag them from and to the dialog, like Firefox does it and how @colomar suggested. Given you can already re-arrange toolbar buttons whilst said

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio marked 2 inline comments as done. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvisangelaccio, #frameworks, #vdg, dfaure Cc: ngraham, colomar, abetts, apol

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvisangelaccio, #frameworks, #vdg, dfaure Cc: ngraham, colomar, abetts, apol

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio updated this revision to Diff 22241. elvisangelaccio added a comment. - Implement a global 'edit mode' that enables both kind of drags (whole toolbar + actions within the toolbar). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8773?vs=2221

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio added a comment. In https://phabricator.kde.org/D8773#166846, @colomar wrote: > Why don't we do this the way Firefox does it: Have a menu entry that puts the whole UI in config mode. > That works far better then trying to make each individual config feature discoverabl

D8773: Improve discoverability of drag-and-drop of toolbar actions

abetts added a comment. My perspective here is that instead of using an actual checkbox to enable the dragging, I would create visual handles instead. Maybe something like this: F5489078: Group.png Why? Because checkboxes generally don't enab

D8773: Improve discoverability of drag-and-drop of toolbar actions

colomar added a comment. Why don't we do this the way Firefox does it: Have a menu entry that puts the whole UI in config mode. That works far better then trying to make each individual config feature discoverable. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8

D8773: Improve discoverability of drag-and-drop of toolbar actions

dfaure added a comment. I like the idea. I'm just not sure about the exact wording of the action, but I'll let the VDG decide on that. INLINE COMMENTS > apol wrote in ktoolbar.cpp:410 > Isn't it better to set a parent like for the other ona than use the > QScopedPointer? I'm also surp

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio added a comment. In https://phabricator.kde.org/D8773#166734, @apol wrote: > Won't un/locking already change the fact that they can be dragged? Or what is it going to become draggable? No, "unlocking" means you can drag the whole toolbar, e.g. from the top to the

D8773: Improve discoverability of drag-and-drop of toolbar actions

apol added a comment. Won't un/locking already change the fact that they can be dragged? Or what is it going to become draggable? INLINE COMMENTS > ktoolbar.cpp:410 > > +contextEditableAction.reset(new > KToggleAction(QIcon::fromTheme(QStringLiteral("document-edit")), > i18nc("@i

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio added a dependent revision: D8774: Show Configure Toolbars dialog as modal. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvisangelaccio, #frameworks, #vdg, dfaure

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio added a comment. Screenshot: F5488679: Screenshot_20171112_115923.png REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvisangelaccio, #frameworks, #vdg, dfaure

D8773: Improve discoverability of drag-and-drop of toolbar actions

elvisangelaccio created this revision. elvisangelaccio added reviewers: Frameworks, VDG, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY Drag-and-drop of toolbar actions is a nice feature that currently is basically hidden to end users. The only way to enable it is