D8791: Avoid inconsistent passworddialog

2017-11-25 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:0919a1b8ba52: Avoid inconsistent passworddialog (authored 
by cryptodude, committed by ngraham).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8791?vs=22268=22939

REVISION DETAIL
  https://phabricator.kde.org/D8791

AFFECTED FILES
  src/kpassworddialog.cpp

To: cryptodude, dfaure, cfeck, ngraham
Cc: ngraham, #frameworks

D8791: Avoid inconsistent passworddialog

2017-11-22 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.


  Sure.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8791

To: cryptodude, dfaure, cfeck, ngraham
Cc: ngraham, #frameworks

D8791: Avoid inconsistent passworddialog

2017-11-21 Thread Nathaniel Graham 
ngraham added a comment.


  @dfaure, does this look sane and sensible to you?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8791

To: cryptodude, dfaure, cfeck, ngraham
Cc: ngraham, #frameworks

D8791: Avoid inconsistent passworddialog

2017-11-20 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8791

To: cryptodude, dfaure, cfeck, ngraham
Cc: ngraham, #frameworks

D8791: Avoid inconsistent passworddialog

2017-11-20 Thread Kees vd Broek 
cryptodude edited the test plan for this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8791

To: cryptodude, dfaure, cfeck
Cc: ngraham, #frameworks

D8791: Avoid inconsistent passworddialog

2017-11-20 Thread Kees vd Broek 
cryptodude added a comment.


  >   so if something doesn't work, let me know ;-)
  
  It took me quite some figuring out how this works. Thanks for stating it 
really should work.  The only way that I managed to get it to work is load the 
project in QtCreator and select the 'debug' build there. I'm guessing it needs 
some tricky cmake flags and library flags (from konsole it always uses the 
distro library).

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8791

To: cryptodude, dfaure, cfeck
Cc: ngraham, #frameworks

D8791: Avoid inconsistent passworddialog

2017-11-20 Thread David Faure 
dfaure added a comment.


  The whole point of KDE Frameworks is that you don't need a "full up-to-date 
KDE development system".
  
  You can just install distro packages for Qt5 devel, and ECM, and then compile 
and test kwidgetaddons from git without even having to install it, using a 
unittest and/or a test program.
  I worked on making this possible, so if something doesn't work, let me know 
;-)
  
  (depending on your distro, you might have to lower the required version of 
ECM in CMakeLists.txt, but that is usually fine)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8791

To: cryptodude, dfaure, cfeck
Cc: ngraham, #frameworks

D8791: Avoid inconsistent passworddialog

2017-11-20 Thread Kees vd Broek 
cryptodude added a comment.


  The changes are pretty simple, but testing it would require a lot of work as 
it requires a full up-to-date KDE development system and I just don't have that 
option.
  
  So I can't give you a screenshot, as the "test plan" indicates, I visually 
can't test it.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8791

To: cryptodude, dfaure, cfeck
Cc: ngraham, #frameworks

D8791: Avoid inconsistent passworddialog

2017-11-13 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks for the patch! For UI changes, a before-and-after screenshot pair is 
always nice. Also, have you tested that the default username-and-password combo 
still works?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8791

To: cryptodude, dfaure, cfeck
Cc: ngraham, #frameworks

D8791: Avoid inconsistent passworddialog

2017-11-13 Thread Kees vd Broek 
cryptodude created this revision.
cryptodude added reviewers: dfaure, cfeck.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  In case the user starts the KPasswordDialog without the 
KPasswordDialog::ShowUsernameLine,
  the dialog will look a bit odd as the text will still state;
   "Supply a username and password below."
  while there is no username field to fill in.
  
  This patch adds a string and sets it in the constructor on the "prompt" to 
match the flags passed into the constructor.

TEST PLAN
  Needs more eyes and maybe someone has testcases...

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8791

AFFECTED FILES
  src/kpassworddialog.cpp

To: cryptodude, dfaure, cfeck
Cc: #frameworks