D8870: Synchronize the component with the one in Kirigami
This revision was automatically updated to reflect the committed changes. Closed by commit R242:aa4aa72d6322: Synchronize the component with the one in Kirigami (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8870?vs=22545=22641 REVISION DETAIL https://phabricator.kde.org/D8870 AFFECTED FILES src/declarativeimports/plasmaextracomponents/qml/Heading.qml To: apol, #plasma, mart Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8870: Synchronize the component with the one in Kirigami
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8870 To: apol, #plasma, mart Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8870: Synchronize the component with the one in Kirigami
apol updated this revision to Diff 22544. apol added a comment. Search all frameworks together as components REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8870?vs=22531=22544 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8870 AFFECTED FILES CMakeLists.txt src/declarativeimports/plasmaextracomponents/qml/Heading.qml To: apol, #plasma Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8870: Synchronize the component with the one in Kirigami
apol updated this revision to Diff 22545. apol added a comment. unrelated things REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8870?vs=22544=22545 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8870 AFFECTED FILES src/declarativeimports/plasmaextracomponents/qml/Heading.qml To: apol, #plasma Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8870: Synchronize the component with the one in Kirigami
apol added a comment. Yes, this works, the code in question was in SystemTray, it looks just fine there. Also I've been using Heading in Discover for months and never saw this issue. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8870 To: apol, #plasma Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8870: Synchronize the component with the one in Kirigami
broulik added a comment. Are you sure this results in the same "bottom gap" below the item? Perhaps `bottomPadding` (new in Qt 5.6) could help here? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8870 To: apol, #plasma Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8870: Synchronize the component with the one in Kirigami
apol created this revision. apol added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Using the height property together with paintedHeight had binding loops. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8870 AFFECTED FILES src/declarativeimports/plasmaextracomponents/qml/Heading.qml To: apol, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
