D8871: Don't look for /etc/kderc every single time

2017-11-20 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:f1e5d65ec128: Dont look for /etc/kderc every single 
time (authored by apol).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8871?vs=22537=22642

REVISION DETAIL
  https://phabricator.kde.org/D8871

AFFECTED FILES
  src/core/kconfig.cpp

To: apol, #frameworks, mpyne, dfaure
Cc: dfaure, mpyne

D8871: Don't look for /etc/kderc every single time

2017-11-20 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.


  Patch looks good. Commit log looks wrong, it's not /etc/kderc but /etc/kde5rc.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8871

To: apol, #frameworks, mpyne, dfaure
Cc: dfaure, mpyne

D8871: Don't look for /etc/kderc every single time

2017-11-17 Thread Michael Pyne 
mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.


  +1

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8871

To: apol, #frameworks, mpyne
Cc: mpyne

D8871: Don't look for /etc/kderc every single time

2017-11-17 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Every time we open a configuration file, we are checking if this file is 
there.
  Since it's a sysadmin setting I'd say it's fine to assume that it's not 
appearing
  and disappearing.
  Also we are not supporting the case of the file changing during runtime or so.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8871

AFFECTED FILES
  src/core/kconfig.cpp

To: apol, #frameworks