D8912: Added a set of Game Folder icons

2018-11-14 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:8761b763eacd: Added a set of Game Folder icons (authored by andreyorst, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D8912: Added a set of Game Folder icons

2018-11-14 Thread Noah Davis
ndavis added a comment. It's been 3 days and no response, so I guess I'll land it. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D8912 (branched from master) REVISION DETAIL https://phabricator.kde.org/D8912 To: ndavis, #vdg, ngraham, andreyorst Cc: aaronhoneycutt, bruns, ngraham,

D8912: Added a set of Game Folder icons

2018-11-10 Thread Aaron Honeycutt
aaronhoneycutt added a comment. This looks awesome folks! Great work! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8912 To: andreyorst, #vdg, ngraham Cc: aaronhoneycutt, bruns, ngraham, kde-frameworks-devel, ndavis, michaelh

D8912: Added a set of Game Folder icons

2018-11-10 Thread Noah Davis
ndavis added a comment. Now for some feedback about the latest changes to the icon: Much better! The area around the joysticks could use some cleaning up though. At 100% size, it's not possible to see the joysticks. My suggestion would be to remove the joysticks, but keep the bumps that

D8912: Added a set of Game Folder icons

2018-11-10 Thread Noah Davis
ndavis added a comment. In D8912#357376 , @ngraham wrote: > @ndavis can help with this, but yeah, we really need to add this information to https://hig.kde.org/style/icon.html. Noah, since you know how to do that, would you mind submitting a HIG

D8912: Added a set of Game Folder icons

2018-11-10 Thread Noah Davis
ndavis added a comment. In D8912#357374 , @andreyorst wrote: > I've thought that that's why we have separate breeze and breeze-dark icons. I don't know how to make it dynamic in Inkscape. Is there's any guide for this? It's a PITA, but to

D8912: Added a set of Game Folder icons

2018-11-10 Thread Nathaniel Graham
ngraham added a comment. In D8912#357374 , @andreyorst wrote: > I've had so bad times of getting rid of Cuttlefish on my system because there was no package with the similar name. I'll install it though. If you prefer to use a CLi package

D8912: Added a set of Game Folder icons

2018-11-10 Thread Andrey Orst
andreyorst added a comment. > Phabricator unfortunately doesn't offer SVG previews, so posting new screenshots every time you update the diff is appreciated. :) Got it. > You can generally find it by searching for "Cuttlefish" in Discover. I've had so bad times of getting rid

D8912: Added a set of Game Folder icons

2018-11-10 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Phabricator unfortunately doesn't offer SVG previews, so posting new screenshots every time you update the diff is appreciated. :) Also, if you don't already know about it,

D8912: Added a set of Game Folder icons

2018-11-09 Thread Andrey Orst
andreyorst updated this revision to Diff 45220. andreyorst added a comment. - made controll buttons 1.2px instead of 1px. Now 16 and 22 px icons will have slope somewhat between proposed variants. Looks crisp enough on my setup REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D8912: Added a set of Game Folder icons

2018-11-09 Thread Andrey Orst
andreyorst updated this revision to Diff 45219. andreyorst added a comment. fix links REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8912?vs=45202=45219 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8912 AFFECTED FILES

D8912: Added a set of Game Folder icons

2018-11-09 Thread Stefan Brüns
bruns added a comment. In D8912#357075 , @ndavis wrote: > In D8912#357072 , @bruns wrote: > > > Try making the buttons somewhat larger. A 1px circle ends up as light gray square. > > > Think

D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment. In D8912#357074 , @ngraham wrote: > In D8912#357052 , @ndavis wrote: > > > F6403963: Screenshot_20181109_154449.png > > > > Ah,

D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment. In D8912#357072 , @bruns wrote: > Try making the buttons somewhat larger. A 1px circle ends up as light gray square. Think that's perfectly fine. If they were larger, they would completely dominate the icon and

D8912: Added a set of Game Folder icons

2018-11-09 Thread Nathaniel Graham
ngraham added a comment. In D8912#357052 , @ndavis wrote: > F6403963: Screenshot_20181109_154449.png > > Ah, that's much better. The buttons and D-pad are much easier to see. Try making the sides

D8912: Added a set of Game Folder icons

2018-11-09 Thread Stefan Brüns
bruns added a comment. Try making the buttons somewhat larger. A 1px circle ends up as light gray square. INLINE COMMENTS > folder-games.svg:93 > + transform="translate(0,-292.76667)"> > + + width="0" Remove all these leftover rects .. REPOSITORY R266 Breeze Icons

D8912: Added a set of Game Folder icons

2018-11-09 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > folder-games.svg:73 > + inkscape:cy="10.469244" > + inkscape:document-units="mm" > + inkscape:current-layer="layer1-3-5" switch the document units to px, the values are shorter then. > folder-games.svg:1 >

D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment. F6403963: Screenshot_20181109_154449.png Ah, that's much better. The buttons and D-pad are much easier to see. Try making the sides straight since the angle is pretty small for that size already. Kind of like this:

D8912: Added a set of Game Folder icons

2018-11-09 Thread Andrey Orst
andreyorst updated this revision to Diff 45202. andreyorst added a comment. Changed icons so they look crisp REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8912?vs=22644=45202 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8912

D8912: Added a set of Game Folder icons

2018-11-09 Thread Andrey Orst
andreyorst added a comment. Understood. Yeh, now I see it. I have very poor eyesight, I'll fixt it REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8912 To: andreyorst, #vdg Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns

D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment. In D8912#356590 , @andreyorst wrote: > > @andreyorst, if you're still around, we can review this patch and land it once necessary changes are made. > > Yeah, I'm here! I'd like to make desired changes myself. > > >

D8912: Added a set of Game Folder icons

2018-11-08 Thread Andrey Orst
andreyorst added a comment. > @andreyorst, if you're still around, we can review this patch and land it once necessary changes are made. Yeah, I'm here! I'd like to make desired changes myself. > Nice job on the 64 px icons! However, I noticed that the 16 and 22 px icons use a

D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment. If you do need to, you click on the Add Action... button that's above the comment text box and choose "Commandeer Revision" Anyway, I agree, let's wait for @andreyorst for a bit. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8912

D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment. In D8912#356508 , @ngraham wrote: > All right, let's wait then. You wanna keep an eye on this and make sure it doesn't get lost again? Sure. Is there anything special I have to do to commandeer it if he doesn't

D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment. All right, let's wait then. You wanna keep an eye on this and make sure it doesn't get lost again? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8912 To: andreyorst, #vdg Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns

D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment. In D8912#356470 , @ngraham wrote: > Now that I think about it, you can probably commandeer it and finish it up now, and once it's ready we can land it with @andreyorst's authorship information. Does that sound okay?

D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment. Now that I think about it, you can probably commandeer it and finish it up now, and once it's ready we can land it with @andreyorst's authorship information. Does that sound okay? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8912

D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment. In D8912#356335 , @ngraham wrote: > Oh gosh, how did we miss this? Yikes, I'm very sorry about that. > > @andreyorst, if you're still around, we can review this patch and land it once necessary changes are made. If

D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment. Oh gosh, how did we miss this? Yikes, I'm very sorry about that. @andreyorst, if you're still around, we can review this patch and land it once necessary changes are made. If not, maybe @ndavis should commandeer this revision and finish it up. REPOSITORY

D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Nice job on the 64 px icons! However, I noticed that the 16 and 22 px icons use a different style and are blurry. Perhaps you should try making the styles more similar to the 64 px style and

D8912: Added a set of Game Folder icons

2017-11-20 Thread David Edmundson
davidedmundson added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8912 To: andreyorst, #vdg Cc: #frameworks

D8912: Added a set of Game Folder icons

2017-11-20 Thread Andrey Orst
andreyorst created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Created an icons for game folders based on game category icon F5499519: image.png REPOSITORY