D8912: Added a set of Game Folder icons

2018-11-14 Thread Noah Davis
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:8761b763eacd: Added a set of Game Folder icons (authored 
by andreyorst, committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8912?vs=45338=45445

REVISION DETAIL
  https://phabricator.kde.org/D8912

AFFECTED FILES
  icons-dark/places/16/folder-games.svg
  icons-dark/places/22/folder-games.svg
  icons-dark/places/32/folder-games.svg
  icons-dark/places/64/folder-games.svg
  icons-dark/places/symbolic/folder-games-symbolic.svg
  icons/places/16/folder-games.svg
  icons/places/22/folder-games.svg
  icons/places/32/folder-games.svg
  icons/places/64/folder-games.svg
  icons/places/symbolic/folder-games-symbolic.svg

To: ndavis, #vdg, ngraham, andreyorst
Cc: aaronhoneycutt, bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-14 Thread Noah Davis
ndavis added a comment.


  It's been 3 days and no response, so I guess I'll land it.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D8912 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: ndavis, #vdg, ngraham, andreyorst
Cc: aaronhoneycutt, bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-10 Thread Aaron Honeycutt
aaronhoneycutt added a comment.


  This looks awesome folks! Great work!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg, ngraham
Cc: aaronhoneycutt, bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-10 Thread Noah Davis
ndavis added a comment.


  Now for some feedback about the latest changes to the icon:
  
  Much better! The area around the joysticks could use some cleaning up though. 
At 100% size, it's not possible to see the joysticks. My suggestion would be to 
remove the joysticks, but keep the bumps that would hold the joysticks. Like so:
  F6410849: Screenshot_20181110_115557.png 

  
  I would suggest converting the stroke to a path since sometimes strokes get 
distorted by some SVG viewers, but I tried it myself and it completely 
butchered your icon. Why? Who knows. Maybe we shouldn't worry too much about it 
for now and if it becomes an issue, I can fix it later.
  
  Lastly, make sure the 16, 22, 32 and 64 px icons are all using the same 
style. The original 64px style looked good, but it did not scale down very 
well. The new style for the smaller icons should scale up easily. In general, I 
find it easier to create a consistent design if I start with the smallest icon 
I need to make.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-10 Thread Noah Davis
ndavis added a comment.


  In D8912#357376 , @ngraham wrote:
  
  > @ndavis can help with this, but yeah, we really need to add this 
information to https://hig.kde.org/style/icon.html. Noah, since you know how to 
do that, would you mind submitting a HIG patch to add it to the Icons page? 
Thanks!
  
  
  It's actually already in the HIG, kind of, but it's not obvious. A rewrite 
would help a lot.
  
  > For more technical details of how to use colors in icons see this blog post
  
  It links to http://notmart.org/blog/2016/05/icon-colors/

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-10 Thread Noah Davis
ndavis added a comment.


  In D8912#357374 , @andreyorst wrote:
  
  > I've thought that that's why we have separate breeze and breeze-dark icons. 
I don't know how to make it dynamic in Inkscape. Is there's any guide for this?
  
  
  It's a PITA, but to do that right now, you actually need to open up the SVG 
in a text editor and add the code. It's not that hard, but it can be tedious if 
you don't automate it or at least use Search and Replace in Kate. It's also not 
easy to read the code unless you use an SVG optimizer with an option to make 
the code pretty. Usually, I run my icons through `svgo --pretty -i 
some-icon.svg` or SVG Cleaner (package is usually called `svgcleaner`) with 
these settings:
  F6410771: Screenshot_20181110_105723.png 

  F6410767: Screenshot_20181110_105237.png 

  
  Running your SVGs through an SVG optimizer is usually a good thing to do 
anyway since it can reduce the size of your SVGs by 80-90%. Inkscape adds a lot 
of extra data that is useful for editing SVGs, but not for displaying them. 
Sometimes SVG optimizers can also help you get past Inkscape bugs.
  
  As an example of how to do this, I'll use the gray 16px folder-games icon. 
After running it through SVG Cleaner with those settings, I get this:
  
http://www.w3.org/2000/svg;>





  
  First, add the style sheet just under line 1:
  

.ColorScheme-Text {
color:#4d4d4d;
}

  
  Second, add the ColorScheme class. In this case, I'll add it to the existing 
group (`` makes a group) so that it affects everything in the group:
  

  
  Third, change all of the colors to "currentColor":
  
  Use `stroke="currentColor"` for strokes and `fill="currentColor"` for shapes.
  
  In the end, I get this:
  
http://www.w3.org/2000/svg;>

.ColorScheme-Text {
color:#4d4d4d;
}






  
  For the breeze-dark icons, just change `#4d4d4d` in the stylesheet to 
`#f2f2f2`.
  
  You don't need to do any of the stylesheet stuff for color icons, including 
the 32 and 64 px folder-games icons, but you should still run them through an 
SVG optimizer to save space. Also, Inkscape adds all the extra junk back every 
time you save a change in inkscape, so you'll have to make sure you use the SVG 
optimizer again if you make a change in inkscape.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-10 Thread Nathaniel Graham
ngraham added a comment.


  In D8912#357374 , @andreyorst wrote:
  
  > I've had so bad times of getting rid of Cuttlefish on my system because 
there was no package with the similar name. I'll install it though.
  
  
  If you prefer to use a CLi package manager, the package name is generally 
`plasma-sdk` or something like that.
  
  > What's a Discover anyways? Do I need it to make icons?
  
  Discover is KDE's software center/app store. Discover makes it really easy to 
find, install, and remove apps, like Cuttlefish.
  
  >> But there is a real problem the small line-art representations don't 
change their color properly in the dark version
  > 
  > I've thought that that's why we have separate breeze and breeze-dark icons. 
I don't know how to make it dynamic in Inkscape. Is there's any guide for this?
  
  @ndavis can help with this, but yeah, we really need to add this information 
to https://hig.kde.org/style/icon.html. Noah, since you know how to do that, 
would you mind submitting a HIG patch to add it to the Icons page? Thanks!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-10 Thread Andrey Orst
andreyorst added a comment.


  > Phabricator unfortunately doesn't offer SVG previews, so posting new 
screenshots every time you update the diff is appreciated. :)
  
  Got it.
  
  > You can generally find it by searching for "Cuttlefish" in Discover.
  
  I've had so bad times of getting rid of Cuttlefish on my system because there 
was no package with the similar name. I'll install it though. What's a Discover 
anyways? Do I need it to make icons?
  
  > But there is a real problem the small line-art representations don't change 
their color properly in the dark version
  
  I've thought that that's why we have separate breeze and breeze-dark icons. I 
don't know how to make it dynamic in Inkscape. Is there's any guide for this?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-10 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Phabricator unfortunately doesn't offer SVG previews, so posting new 
screenshots every time you update the diff is appreciated. :)
  
  Also, if you don't already know about it, let me introduce you to the 
Cuttlefish tool. You can generally find it by searching for "Cuttlefish" in 
Discover. If not, it usually a part of the plasma-sdk package. It's an icon 
visualization app that really makes this workflow a breeze. Here's a screenshot 
of what I can use it to see:
  
  F6410693: icon.png 
  
  Don't worry about the fact that the smallest size is visual mush; that's the 
8px version which in practice won't be used for a folder icon. But there is a 
real problem the small line-art representations don't change their color 
properly in the dark version:
  
  F6410698: icon dark.png 
  
  There's a CSS stylesheet you have to add to it to make this happen. @ndavis 
can help with this.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-09 Thread Andrey Orst
andreyorst updated this revision to Diff 45220.
andreyorst added a comment.


  - made controll buttons 1.2px instead of 1px. Now 16 and 22 px icons will 
have slope somewhat between proposed variants. Looks crisp enough on my setup

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8912?vs=45219=45220

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8912

AFFECTED FILES
  icons-dark/places/16/folder-games.svg
  icons-dark/places/22/folder-games.svg
  icons-dark/places/32/folder-games.svg
  icons-dark/places/64/folder-games.svg
  icons-dark/places/symbolic/folder-games.svg
  icons/places/16/folder-games.svg
  icons/places/22/folder-games.svg
  icons/places/32/folder-games.svg
  icons/places/64/folder-games.svg
  icons/places/symbolic/folder-games.svg

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-09 Thread Andrey Orst
andreyorst updated this revision to Diff 45219.
andreyorst added a comment.


  fix links

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8912?vs=45202=45219

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8912

AFFECTED FILES
  icons-dark/places/16/folder-games.svg
  icons-dark/places/22/folder-games.svg
  icons-dark/places/32/folder-games.svg
  icons-dark/places/64/folder-games.svg
  icons-dark/places/symbolic/folder-games.svg
  icons/places/16/folder-games.svg
  icons/places/22/folder-games.svg
  icons/places/32/folder-games.svg
  icons/places/64/folder-games.svg
  icons/places/symbolic/folder-games.svg

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-09 Thread Stefan Brüns
bruns added a comment.


  In D8912#357075 , @ndavis wrote:
  
  > In D8912#357072 , @bruns wrote:
  >
  > > Try making the buttons somewhat larger. A 1px circle ends up as light 
gray square.
  >
  >
  > Think that's perfectly fine. If they were larger, they would completely 
dominate the icon and the design of the icon would be have to be completely 
changed to match. With large buttons, a SNES style controller would have to be 
used.
  
  
  Just slightly - 1.1 to 1.2 px diameter.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment.


  In D8912#357074 , @ngraham wrote:
  
  > In D8912#357052 , @ndavis wrote:
  >
  > > F6403963: Screenshot_20181109_154449.png 

  > >
  > > Ah, that's much better. The buttons and D-pad are much easier to see. Try 
making the sides straight since the angle is pretty small for that size 
already. Kind of like this: F6404002: Screenshot_20181109_161045.png 

  >
  >
  > TBH, I kind of prefer the sloped-side version to the proposed straight-side 
version. It looks a bit too much like a Pac-Man ghost to me!
  
  
  Fair enough, though I don't see similarity to Pac-Man ghosts as a con.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment.


  In D8912#357072 , @bruns wrote:
  
  > Try making the buttons somewhat larger. A 1px circle ends up as light gray 
square.
  
  
  Think that's perfectly fine. If they were larger, they would completely 
dominate the icon and the design of the icon would be have to be completely 
changed to match. With large buttons, a SNES style controller would have to be 
used.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-09 Thread Nathaniel Graham
ngraham added a comment.


  In D8912#357052 , @ndavis wrote:
  
  > F6403963: Screenshot_20181109_154449.png 

  >
  > Ah, that's much better. The buttons and D-pad are much easier to see. Try 
making the sides straight since the angle is pretty small for that size 
already. Kind of like this: F6404002: Screenshot_20181109_161045.png 

  
  
  TBH, I kind of prefer the sloped-side version to the proposed straight-side 
version. It looks a bit too much like a Pac-Man ghost to me!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-09 Thread Stefan Brüns
bruns added a comment.


  Try making the buttons somewhat larger. A 1px circle ends up as light gray 
square.

INLINE COMMENTS

> folder-games.svg:93
> + transform="translate(0,-292.76667)">
> + +   width="0"

Remove all these leftover rects ..

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-09 Thread Stefan Brüns
bruns added inline comments.

INLINE COMMENTS

> folder-games.svg:73
> + inkscape:cy="10.469244"
> + inkscape:document-units="mm"
> + inkscape:current-layer="layer1-3-5"

switch the document units to px, the values are shorter then.

> folder-games.svg:1
> +/home/andreyorst/Git/breeze-icons/icons-dark/places/16/folder-games.svg

make sure the symlink is a relative one

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment.


  F6403963: Screenshot_20181109_154449.png 

  
  Ah, that's much better. The buttons and D-pad are much easier to see. Try 
making the sides straight since the angle is pretty small for that size 
already. Kind of like this: F6404002: Screenshot_20181109_161045.png 

  
  Here's the SVG of that example icon if you want it. I made the shapes with 
rectangles, circles, Path->Union (`Ctrl`+`+`) and Path->Difference 
(`Ctrl`+`-`). BTW, I'm not saying you have to do it like that, it's still your 
project.
  F6404009: game_controller16.svg 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-09 Thread Andrey Orst
andreyorst updated this revision to Diff 45202.
andreyorst added a comment.


  Changed icons so they look crisp

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8912?vs=22644=45202

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8912

AFFECTED FILES
  icons-dark/places/16/folder-games.svg
  icons-dark/places/22/folder-games.svg
  icons-dark/places/32/folder-games.svg
  icons-dark/places/64/folder-games.svg
  icons-dark/places/symbolic/folder-games.svg
  icons/places/16/folder-games.svg
  icons/places/22/folder-games.svg
  icons/places/32/folder-games.svg
  icons/places/64/folder-games.svg
  icons/places/symbolic/folder-games.svg

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-09 Thread Andrey Orst
andreyorst added a comment.


  Understood. Yeh, now I see it. I have very poor eyesight, I'll fixt it

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment.


  In D8912#356590 , @andreyorst wrote:
  
  > > @andreyorst, if you're still around, we can review this patch and land it 
once necessary changes are made.
  >
  > Yeah, I'm here! I'd like to make desired changes myself.
  >
  > > Nice job on the 64 px icons! However, I noticed that the 16 and 22 px 
icons use a different style and are blurry. Perhaps you should try making the 
styles more similar to the 64 px style and see if you can move, resize or 
remove any details that don't line up with pixels.
  >
  > So the reason behind this was, that with outline style for 16 and 22 px 
icons all elements like buttons were too small and looked really bad. I've 
tried lot of variants and decided to go for filled icon in the same way how it 
is done for `network-server` icon, which is using (sort of) outline for 64 px 
and solid for 22 px. However (the ticket is quite old) I've changed this 
somewhere during this year, and currently in my system all icons are using 
filled icons, since I feel that this fits more with original style of 
`applications-games` icon (and most of game controllers are black too). I'll 
submit updated patch this evening.
  
  
  Fair enough. I'll be waiting.
  
  >> I noticed that the 16 and 22 px icons use a different style and are blurry
  > 
  > What screen resolution do you have? Rightnow it looks fine on my system 
with 1920x1080 screen. I'll check it at work with 2k screen and scaling turned 
off.
  
  I also have 1920x1080 screen, but it shouldn't matter as long as we're both 
at 1x scaling. You don't see how blurry it is compared to the other icons in 
your screenshot?
  F6403322: Screenshot_20181109_091658.png 

  
  Let me show you the issue up close. You see how it doesn't line up well with 
the grid? 1 grid square = 1 pixel.
  F6403326: Screenshot_20181109_092307.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Andrey Orst
andreyorst added a comment.


  > @andreyorst, if you're still around, we can review this patch and land it 
once necessary changes are made.
  
  Yeah, I'm here! I'd like to make desired changes myself.
  
  > Nice job on the 64 px icons! However, I noticed that the 16 and 22 px icons 
use a different style and are blurry. Perhaps you should try making the styles 
more similar to the 64 px style and see if you can move, resize or remove any 
details that don't line up with pixels.
  
  So the reason behind this was, that with outline style for 16 and 22 px icons 
all elements like buttons were too small and looked really bad. I've tried lot 
of variants and decided to go for filled icon in the same way how it is done 
for `network-server` icon, which is using (sort of) outline for 64 px and solid 
for 22 px. However (the ticket is quite old) I've changed this somewhere during 
this year, and currently in my system all icons are using filled icons, since I 
feel that this fits more with original style of `applications-games` icon (and 
most of game controllers are black too). I'll submit updated patch this evening.
  
  > I noticed that the 16 and 22 px icons use a different style and are blurry
  
  What screen resolution do you have? Rightnow it looks fine on my system with 
1920x1080 screen. I'll check it at work with 2k screen and scaling turned off.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment.


  If you do need to, you click on the Add Action... button that's above the 
comment text box and choose "Commandeer Revision"
  
  Anyway, I agree, let's wait for @andreyorst for a bit.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment.


  In D8912#356508 , @ngraham wrote:
  
  > All right, let's wait then. You wanna keep an eye on this and make sure it 
doesn't get lost again?
  
  
  Sure. Is there anything special I have to do to commandeer it if he doesn't 
reply? Like an Arcanist or Git command or something?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment.


  All right, let's wait then. You wanna keep an eye on this and make sure it 
doesn't get lost again?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment.


  In D8912#356470 , @ngraham wrote:
  
  > Now that I think about it, you can probably commandeer it and finish it up 
now, and once it's ready we can land it with @andreyorst's authorship 
information. Does that sound okay?
  
  
  Sure, but I saw this diff posted on Reddit here: 
https://old.reddit.com/r/linux/comments/9vaq3x/kde_plasma_5143_bugfix_release_for_november_with/e9b06iv/
  
  There's a decent chance he'll answer soon and I don't want to take over his 
project without giving him a chance to reply.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment.


  Now that I think about it, you can probably commandeer it and finish it up 
now, and once it's ready we can land it with @andreyorst's authorship 
information. Does that sound okay?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment.


  In D8912#356335 , @ngraham wrote:
  
  > Oh gosh, how did we miss this? Yikes, I'm very sorry about that.
  >
  > @andreyorst, if you're still around, we can review this patch and land it 
once  necessary changes are made. If not, maybe @ndavis should commandeer this 
revision and finish it up.
  
  
  If it's necessary, I would be fine with commandeering.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment.


  Oh gosh, how did we miss this? Yikes, I'm very sorry about that.
  
  @andreyorst, if you're still around, we can review this patch and land it 
once  necessary changes are made. If not, maybe @ndavis should commandeer this 
revision and finish it up.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  Nice job on the 64 px icons! However, I noticed that the 16 and 22 px icons 
use a different style and are blurry. Perhaps you should try making the styles 
more similar to the 64 px style and see if you can move, resize or remove any 
details that don't line up with pixels.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: kde-frameworks-devel, ndavis, michaelh, ngraham, bruns, #frameworks


D8912: Added a set of Game Folder icons

2017-11-20 Thread David Edmundson
davidedmundson added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: #frameworks


D8912: Added a set of Game Folder icons

2017-11-20 Thread Andrey Orst
andreyorst created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Created an icons for game folders based on  game category icon
  F5499519: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

AFFECTED FILES
  icons-dark/places/16/folder-games.svg
  icons-dark/places/22/folder-games.svg
  icons-dark/places/32/folder-games.svg
  icons-dark/places/64/folder-games.svg
  icons-dark/places/symbolic/folder-games-symbolic.svg
  icons/places/16/folder-games.svg
  icons/places/22/folder-games.svg
  icons/places/32/folder-games.svg
  icons/places/64/folder-games.svg
  icons/places/symbolic/folder-games-symbolic.svg

To: andreyorst
Cc: #frameworks