D8945: Return a valid bookmark object for any entry in KFilePlacesModel

2017-11-27 Thread Phabricator 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:531d7759578e: Return a valid bookmark object for any 
entry in KFilePlacesModel (authored by Renato Araujo Oliveira Filho 
renato.ara...@kdab.com).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8945?vs=23011=23017

REVISION DETAIL
  https://phabricator.kde.org/D8945

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

2017-11-27 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 23011.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8945?vs=22964=23011

REVISION DETAIL
  https://phabricator.kde.org/D8945

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

2017-11-27 Thread Franck Arrecot 
franckarrecot added a dependent revision: D8450: User can now hide an entire 
places group from KFilePlacesView.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8945

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

2017-11-27 Thread Franck Arrecot 
franckarrecot added a dependent revision: D8367: Hidding place groups 
implementation in KFilePlacesModel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8945

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

2017-11-26 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 22964.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8945?vs=22953=22964

REVISION DETAIL
  https://phabricator.kde.org/D8945

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

2017-11-26 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 22953.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8945?vs=22815=22953

REVISION DETAIL
  https://phabricator.kde.org/D8945

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

2017-11-23 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 22815.
renatoo added a comment.


  Parent branch updated

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8945?vs=22780=22815

REVISION DETAIL
  https://phabricator.kde.org/D8945

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

2017-11-22 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 22780.
renatoo added a comment.


  Updated from master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8945?vs=22768=22780

REVISION DETAIL
  https://phabricator.kde.org/D8945

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

2017-11-22 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 22768.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8945?vs=22757=22768

REVISION DETAIL
  https://phabricator.kde.org/D8945

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

2017-11-22 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 22757.
renatoo added a comment.


  Updated parent brach

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8945?vs=22738=22757

REVISION DETAIL
  https://phabricator.kde.org/D8945

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: renatoo, dfaure
Cc: ngraham, #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

2017-11-22 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8945

To: renatoo, dfaure
Cc: #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

2017-11-22 Thread Renato Oliveira Filho 
renatoo added a dependent revision: D8946: Avoid unnecessary 'dataChanged' 
signal.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8945

To: renatoo, dfaure
Cc: #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

2017-11-22 Thread Renato Oliveira Filho 
renatoo edited the summary of this revision.
renatoo added a reviewer: dfaure.
renatoo added a dependency: D8944: Create a 'KFilePlacesModel::refresh' 
function.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8945

To: renatoo, dfaure
Cc: #frameworks

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

2017-11-22 Thread Renato Oliveira Filho 
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Make sure that 'KFilePlacesModel::bookmarkForIndex' return a bookmark
  for any item in the model.

TEST PLAN
  unit test created

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8945

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: renatoo
Cc: #frameworks