D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

2017-12-05 Thread Nicolas Fella
nicolasfella added a comment. > Yes it does. You don't know it but > m_reply = Daemon::instance()->networkAccessManager()->put(req, m_origin.data()); > in filetransferjob.cpp is using kio. I really didn't know that > Are you sure you know how to run kdeconnect with the patched

D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

2017-12-05 Thread Albert Astals Cid
aacid added a comment. In https://phabricator.kde.org/D9190#176216, @nicolasfella wrote: > I'm sorry, but this does not resolve https://bugs.kde.org/show_bug.cgi?id=386246 for me. KDE Connect's FileTransferJob does not even use KIO's TransferJob. It just extends KJob, so it could be a (

D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

2017-12-05 Thread Nicolas Fella
nicolasfella added a comment. I'm sorry, but this does not resolve https://bugs.kde.org/show_bug.cgi?id=386246 for me. KDE Connect's FileTransferJob does not even use KIO's TransferJob. It just extends KJob, so it could be a (similar) bug there. REPOSITORY R241 KIO REVISION DETAIL http

D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

2017-12-05 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > transferjob.cpp:310-323 > if (m_extraFlags & JobPrivate::EF_TransferJobAsync) { > q->connect(m_outgoingDataSource, SIGNAL(readyRead()), > SLOT(slotDataReqFromDevice())); > q->connect(m_

D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

2017-12-04 Thread Albert Astals Cid
aacid added reviewers: dfaure, apol, albertvaka. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9190 To: aacid, dfaure, apol, albertvaka Cc: #frameworks

D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

2017-12-04 Thread Albert Astals Cid
aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This fixes a regression by the removal of the busy loop call from https://phabricator.kde.org/R241:bcdbe62660a9ca91b0d15f3a9a06a758ec8fdcda