D9275: fix RTL appearance for ComboBox

2018-02-16 Thread Michail Vourlakos
mvourlakos added a comment. @safaalfulaij I created the following for this: https://phabricator.kde.org/D10592 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart, plasma-devel, #frameworks,

D9275: fix RTL appearance for ComboBox

2018-02-16 Thread Michail Vourlakos
mvourlakos added a comment. Latte config window is a Plasma::ConfigView, so it inherates a QQuickView REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh,

D9275: fix RTL appearance for ComboBox

2018-02-16 Thread Safa Alfulaij
safaalfulaij added a comment. Reported: https://bugreports.qt.io/browse/QTBUG-66446 Although this is really unlikly to happen, a widget having a combobox, but this is the case of Latte where the whole config overlay is just a `MouseArea`. REPOSITORY R242 Plasma Framework (Library)

D9275: fix RTL appearance for ComboBox

2018-02-16 Thread Safa Alfulaij
safaalfulaij added a comment. In D9275#207623 , @mvourlakos wrote: > Can you build Latte from master version? All comboboxes in its settings window are PlasmaComponents3 :) Ok, I can assume that Latte doens't have a

D9275: fix RTL appearance for ComboBox

2018-02-16 Thread Michail Vourlakos
mvourlakos added a comment. Can you build Latte from master version? All comboboxes in its settings window are PlasmaComponents3 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart,

D9275: fix RTL appearance for ComboBox

2018-02-16 Thread Safa Alfulaij
safaalfulaij added a comment. I've done some more testing and read some Qt docs. `Popup` item get reparented to the window once displayed, so LayoutMirroring is applied to it only at that point (applying it to the contentItem). So my comments above about `Popup` not inheerting `Item` are

D9275: fix RTL appearance for ComboBox

2018-02-15 Thread Safa Alfulaij
safaalfulaij added a comment. In D9275#207435 , @mvourlakos wrote: > > Would you please add a HACK so that we know when to remove this? > > You mean as a comment ? Yes, preferably with the Qt bug number and some explanation.

D9275: fix RTL appearance for ComboBox

2018-02-15 Thread Michail Vourlakos
mvourlakos added a comment. > Would you please add a HACK so that we know when to remove this? You mean as a comment ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart, plasma-devel,

D9275: fix RTL appearance for ComboBox

2018-02-15 Thread Safa Alfulaij
safaalfulaij added a comment. In D9275#207260 , @mvourlakos wrote: > @mart I fixed this issue by changing these lines to: > > 113LayoutMirroring.enabled: Qt.application.layoutDirection === Qt.RightToLeft > 114

D9275: fix RTL appearance for ComboBox

2018-02-15 Thread Michail Vourlakos
mvourlakos added a comment. @mart I fixed this issue by changing these lines to: 113LayoutMirroring.enabled: Qt.application.layoutDirection === Qt.RightToLeft 114LayoutMirroring.childrenInherit: true REPOSITORY R242 Plasma Framework (Library) REVISION

D9275: fix RTL appearance for ComboBox

2018-02-15 Thread Michail Vourlakos
mvourlakos added a comment. @safaalfulaij @mart we need to revert this... with frameworks 5.43 it reverses list items always!!! The issue is still present when the PlasmaComponents3.ComboBox is used in the Latte settings window, that is the items are not aligned correctly in

D9275: fix RTL appearance for ComboBox

2018-01-14 Thread Safa Alfulaij
safaalfulaij added inline comments. INLINE COMMENTS > ComboBox.qml:113 > highlightMoveDuration: 0 > +LayoutMirroring.enabled: true > +LayoutMirroring.childrenInherit: true So it is true even for LTR locales? REPOSITORY R242 Plasma Framework (Library)

D9275: fix RTL appearance for ComboBox

2018-01-14 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190606, @mvourlakos wrote: > To test it in Latte I added in the head of /shell/package/contents/configuration/AppearanceConfig.qml > > import org.kde.plasma.components 3.0 as PlasmaComponents3 > > > and I set

D9275: fix RTL appearance for ComboBox

2018-01-14 Thread Michail Vourlakos
mvourlakos added a comment. In https://phabricator.kde.org/D9275#190594, @safaalfulaij wrote: > In https://phabricator.kde.org/D9275#190569, @mvourlakos wrote: > > > with your example me I cant reproduce it either... > > I can only reproduce it with Latte Settings window, all other

D9275: fix RTL appearance for ComboBox

2018-01-14 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190569, @mvourlakos wrote: > with your example me I cant reproduce it either... > I can only reproduce it with Latte Settings window, all other components are aligned correctly except the PlasmaComponent3.Combobox list

D9275: fix RTL appearance for ComboBox

2018-01-14 Thread Michail Vourlakos
mvourlakos added a comment. In https://phabricator.kde.org/D9275#190547, @safaalfulaij wrote: > In https://phabricator.kde.org/D9275#190497, @mvourlakos wrote: > > > how did you test it? > > > > I tried in an qml app (Latte dock) by passing the parameter "--reverse"... > > If

D9275: fix RTL appearance for ComboBox

2018-01-13 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190497, @mvourlakos wrote: > how did you test it? > > I tried in an qml app (Latte dock) by passing the parameter "--reverse"... > If your system is already using in RTL language, have you tried with --reverse?

D9275: fix RTL appearance for ComboBox

2018-01-13 Thread Michail Vourlakos
mvourlakos added a comment. In https://phabricator.kde.org/D9275#190473, @safaalfulaij wrote: > In https://phabricator.kde.org/D9275#190464, @mvourlakos wrote: > > > In https://phabricator.kde.org/D9275#190441, @safaalfulaij wrote: > > > > > Can you please explain why these are

D9275: fix RTL appearance for ComboBox

2018-01-13 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190464, @mvourlakos wrote: > In https://phabricator.kde.org/D9275#190441, @safaalfulaij wrote: > > > Can you please explain why these are needed? I tested plasmacomponents3 and the

D9275: fix RTL appearance for ComboBox

2018-01-13 Thread Michail Vourlakos
mvourlakos added a comment. In https://phabricator.kde.org/D9275#190441, @safaalfulaij wrote: > Can you please explain why these are needed? I tested plasmacomponents3 and the combobox was working correctly. It wasnt, use english text in the

D9275: fix RTL appearance for ComboBox

2018-01-12 Thread Michail Vourlakos
This revision was automatically updated to reflect the committed changes. Closed by commit R242:547dade2f803: fix RTL appearance for ComboBox (authored by mvourlakos). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9275?vs=23708=25254

D9275: fix RTL appearance for ComboBox

2018-01-12 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH listrtl REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D9275: fix RTL appearance for ComboBox

2017-12-14 Thread Michail Vourlakos
mvourlakos added a subscriber: mart. mvourlakos added a comment. @mart what about this? are you able to reproduce it in your system? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma Cc: mart, plasma-devel, #frameworks,

D9275: fix RTL appearance for ComboBox

2017-12-14 Thread Michail Vourlakos
mvourlakos added a comment. just noticed that the reviewer is the person that decides to give the green light so it cant be set by the author without prior communication... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos,

D9275: fix RTL appearance for ComboBox

2017-12-14 Thread Michail Vourlakos
mvourlakos removed a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

2017-12-12 Thread Michail Vourlakos
mvourlakos added a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

2017-12-09 Thread Michail Vourlakos
mvourlakos edited the summary of this revision. mvourlakos edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9275: fix RTL appearance for ComboBox

2017-12-09 Thread Michail Vourlakos
mvourlakos updated this revision to Diff 23708. mvourlakos added a comment. - fix typos REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9275?vs=23707=23708 BRANCH listrtl REVISION DETAIL https://phabricator.kde.org/D9275 AFFECTED

D9275: fix RTL appearance for ComboBox

2017-12-09 Thread Michail Vourlakos
mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY --PlasmaComponents3.ComboBox now appears correctly its list items in RTL