This revision was automatically updated to reflect the committed changes.
Closed by commit R241:fc1f2fe296d6: Allow filter places based on alternative
application name (authored by Renato Araujo Oliveira Filho
renato.ara...@kdab.com).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
ngraham added a comment.
Looks like this revision and the two that depend on it have all been accepted
and are ready to land!
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: elvisangelaccio, mlaurent, aacid, ngraham, #frameworks
renatoo updated this revision to Diff 25880.
renatoo added a comment.
Updated @since tag
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9332?vs=24605=25880
REVISION DETAIL
https://phabricator.kde.org/D9332
AFFECTED FILES
aacid added a comment.
Probably the @since needs updating
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: elvisangelaccio, mlaurent, aacid, ngraham, #frameworks
ngraham added a comment.
Is this commitable now?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: elvisangelaccio, mlaurent, aacid, ngraham, #frameworks
renatoo updated this revision to Diff 24605.
renatoo marked 3 inline comments as done.
renatoo added a comment.
Fixed typo
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9332?vs=23930=24605
REVISION DETAIL
https://phabricator.kde.org/D9332
AFFECTED FILES
elvisangelaccio added inline comments.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:145
> +KFilePlacesModel *currentModel = model;
> +if (currentModel == nullptr) {
> +currentModel = m_places;
`if (!currentModel)` ?
> kfileplacesmodel.h:69
> +/**
> +* @brief Construct a
mlaurent added a comment.
Not commited ?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: mlaurent, aacid, ngraham, #frameworks
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: mlaurent, aacid, ngraham, #frameworks
renatoo marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: mlaurent, aacid, ngraham, #frameworks
renatoo updated this revision to Diff 23930.
renatoo added a comment.
Added kf6 comments
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9332?vs=23926=23930
REVISION DETAIL
https://phabricator.kde.org/D9332
AFFECTED FILES
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesmodel.h:72
> +* @param parent Parent object
> +* @since 5.41
> +*/
5.42 and missing //kf6 comment
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: mlaurent,
renatoo updated this revision to Diff 23926.
renatoo marked 3 inline comments as done.
renatoo edited the summary of this revision.
renatoo added a comment.
Added documention for the new constructor
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:1276
> +// create a new entry with alternative application name
> +KBookmark bookmark =
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff
Cc: aacid, ngraham, #frameworks
renatoo marked an inline comment as done.
renatoo added inline comments.
INLINE COMMENTS
> aacid wrote in kfileplacesmodel.h:67
> This breaks ABI so it's not acceptable.
>
> Also how does this fix anything if the new alternativeApplicationName
> parameter is never passed in any of the existing
renatoo updated this revision to Diff 23922.
renatoo added a comment.
Avoid ABI break
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9332?vs=23920=23922
REVISION DETAIL
https://phabricator.kde.org/D9332
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
aacid added inline comments.
INLINE COMMENTS
> kfileplacesmodel.h:67
>
> -KFilePlacesModel(QObject *parent = nullptr);
> +KFilePlacesModel(QObject *parent = nullptr, const QString
> = {});
> ~KFilePlacesModel();
This breaks ABI so it's not acceptable.
Also how does this fix
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff
Cc: ngraham, #frameworks
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff
Cc: #frameworks
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff
Cc: #frameworks
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff
Cc: #frameworks
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff
Cc: #frameworks
renatoo added a reviewer: mwolff.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff
Cc: #frameworks
renatoo added a dependent revision: D9333: Make sure that old ulrs does not
appear duplicated in places model.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo
Cc: #frameworks
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo
Cc: #frameworks
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
You can use a alternative application name to filter items on places
model.
This new parameter will will be use to match the
27 matches
Mail list logo
