mpyne added a comment.
In https://phabricator.kde.org/D9334#180881, @kossebau wrote:
> In https://phabricator.kde.org/D9334#180830, @mpyne wrote:
>
> > In fact this appears to force files containing `K_PLUGIN_FACTORY*` into
being evaluated by CMake's AUTOMOC (other warning fixes
kossebau added a comment.
In https://phabricator.kde.org/D9334#180540, @ngraham wrote:
> We have a report in the wild that this broke compiling KWin with CMake
3.10.x for someone on Gentoo: https://bugs.kde.org/show_bug.cgi?id=387983
Actually did it uncover some issue in
mpyne added a comment.
In fact this appears to force files containing `K_PLUGIN_FACTORY*` into being
evaluated by CMake's AUTOMOC (other warning fixes removed files from
consideration by CMake AUTOMOC).
CMake itself appears to have had an interface change for AUTOMOC between 3.8
and
ngraham added a comment.
We have a report in the wild that this broke compiling KWin with CMake 3.10.x
for someone on Gentoo: https://bugs.kde.org/show_bug.cgi?id=387983
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9334
To: mlaurent, dfaure
Cc: ngraham,
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:fbc5881b916c: Remove cmake 3.10+ warning for users of
K_PLUGIN_FACTORY and… (authored by mlaurent).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
remove_cmake_warning
REVISION DETAIL
https://phabricator.kde.org/D9334
To: mlaurent, dfaure
Cc: #frameworks
mlaurent retitled this revision from "Remove cmake warning" to "Remove cmake
3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON".
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9334
To: mlaurent, dfaure
Cc: #frameworks
