dfaure added a comment.
Put it in the common file, and add an accessor for the other files, for
instance a static method in Solid::NetworkingPrivate.
REPOSITORY
R239 KDELibs4Support
REVISION DETAIL
https://phabricator.kde.org/D9386
To: habacker, dfaure, ltoscano, bcooksley
Cc:
habacker added a comment.
In https://phabricator.kde.org/D9386#181297, @dfaure wrote:
> That's trivial, isn't it? Rename networking.cpp to networking_unix.cpp, and
move to networking.cpp the methods that are platform-independent.
Any idea how to share the line
habacker edited the summary of this revision.
REPOSITORY
R239 KDELibs4Support
REVISION DETAIL
https://phabricator.kde.org/D9386
To: habacker, dfaure, ltoscano, bcooksley
Cc: #frameworks
dfaure added a comment.
That's trivial, isn't it? Rename networking.cpp to networking_unix.cpp, and
move to networking.cpp the methods that are platform-independent.
REPOSITORY
R239 KDELibs4Support
REVISION DETAIL
https://phabricator.kde.org/D9386
To: habacker, dfaure, ltoscano,
habacker closed this revision.
REPOSITORY
R239 KDELibs4Support
REVISION DETAIL
https://phabricator.kde.org/D9386
To: habacker, dfaure, ltoscano, bcooksley
Cc: #frameworks
habacker added a comment.
In https://phabricator.kde.org/D9386#181227, @dfaure wrote:
> If this wasn't kdelibs4support, I'd insist for sharing the implementation
rather than duplicating it.
Would be nice to share, but networking.cpp is only be used on non win32
platform, so how
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
If this wasn't kdelibs4support, I'd insist for sharing the implementation
rather than duplicating it. But oh well :-)
REPOSITORY
R239 KDELibs4Support
BRANCH
master
REVISION DETAIL
habacker created this revision.
habacker added reviewers: dfaure, ltoscano, bcooksley.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Add missing method Solid::NetworkingPrivate::serviceOwnerChanged().
TEST PLAN
