This revision was automatically updated to reflect the committed changes.
Closed by commit R271:76aba6882ae3: Add cmake function
kdbusaddons_generate_dbus_service_file (authored by habacker).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9480?vs=24564=24738#toc
REPOSITORY
R271
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R271 KDBusAddons
BRANCH
arcpatch-D9480
REVISION DETAIL
https://phabricator.kde.org/D9480
To: habacker, dfaure, kfunk
Cc: cgiboudeaux, #frameworks
habacker marked 6 inline comments as done.
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
https://phabricator.kde.org/D9480
To: habacker, dfaure, kfunk
Cc: cgiboudeaux, #frameworks
habacker updated this revision to Diff 24564.
habacker added a comment.
- fixed doc
- check if absolute path on unix
- use cmake variable KDE_INSTALL_FULL_BINDIR
- renamed service file template
REPOSITORY
R271 KDBusAddons
CHANGES SINCE LAST UPDATE
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:63
> + "KF5DBusAddonsMacros.cmake"
> + "dbus.service.in"
> DESTINATION "${CMAKECONFIG_INSTALL_DIR}"
This
cgiboudeaux added inline comments.
INLINE COMMENTS
> KF5DBusAddonsMacros.cmake:4
> +#
> +# kdbusaddons_generate_dbus_service_file(executable name path)
> +#
kdbusaddons_generate_dbus_service_file(EXECUTABLE NAME PATH) to improve the
readability.
Please also document each parameter.
>
habacker added a reviewer: kfunk.
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
https://phabricator.kde.org/D9480
To: habacker, dfaure, kfunk
Cc: #frameworks
habacker created this revision.
habacker added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This function is added to hide platform-specific implementation details
when creating dbus service
