D9815: [KFileItem] Use "emblem-shared" for shared files

2018-01-12 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:5aa5de9a7a07: [KFileItem] Use emblem-shared 
for shared files (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9815?vs=25149=25232

REVISION DETAIL
  https://phabricator.kde.org/D9815

AFFECTED FILES
  src/core/kfileitem.cpp

To: broulik, #frameworks, dfaure, andreask, andreaska, apol
Cc: apol

D9815: [KFileItem] Use "emblem-shared" for shared files

2018-01-12 Thread Aleix Pol Gonzalez 
apol accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9815

To: broulik, #frameworks, dfaure, andreask, andreaska, apol
Cc: apol

D9815: [KFileItem] Use "emblem-shared" for shared files

2018-01-12 Thread Andreas Kainz 
andreaska accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9815

To: broulik, #frameworks, dfaure, andreask, andreaska
Cc: apol

D9815: [KFileItem] Use "emblem-shared" for shared files

2018-01-12 Thread Kai Uwe Broulik 
broulik added a comment.


  F5641972: Screenshot_20180112_132818.png 

  Andreas added an "emblem-shared" icon

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9815

To: broulik, #frameworks, dfaure, andreask
Cc: apol

D9815: [KFileItem] Use "emblem-shared" for shared files

2018-01-12 Thread Andreas Kainz 
andreask added a comment.


  add an real emblem-shared icon cause the existing one was a symbolic one for 
gnome. should work now so +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9815

To: broulik, #frameworks, dfaure, andreask
Cc: apol

D9815: [KFileItem] Use "emblem-shared" for shared files

2018-01-11 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1, definitely a step forward, although it seems a bit weird that a shared 
emblem and action is the same icon, no?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9815

To: broulik, #frameworks, dfaure, andreask
Cc: apol

D9815: [KFileItem] Use "emblem-shared" for shared files

2018-01-11 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Frameworks, dfaure, andreask.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  "network-workgroup" might work at 16px size but it's semantically incorrect 
and when rendered at larger size it turns into a folder and isn't suitable as 
an overlay.

TEST PLAN
  The icon doesn't actually exist yet, there's emblem-shared-symbolic but I 
didn't want to explicitly mention a symbolic icon as none of the other emblems 
did. I requested one (basically just a symlink to the other) in Bug 388802
  
  Before
  F5637709: Screenshot_20180111_121040.png 

  After
  F5637710: Screenshot_20180111_121015.png 

  
  I'm also fine with an all new icon, Andreas?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9815

AFFECTED FILES
  src/core/kfileitem.cpp

To: broulik, #frameworks, dfaure, andreask