D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread David Faure
dfaure added a comment. Done, kwidgetaddons-5.42.1 is out: https://download.kde.org/stable/frameworks/5.42/ REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9884 To: sars, #frameworks, mlaurent Cc: dhaumann, dfaure, ltoscano

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Dominik Haumann
dhaumann added subscribers: dfaure, dhaumann. dhaumann added a comment. @dfaure Can we provide an update to KWidgetAddons? Is this feasible? If not, we should at least announce this bug on kde-distro-packag...@kde.org, since this breaks Kate. Second question: How did this happen in the f

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Kåre Särs
This revision was automatically updated to reflect the committed changes. Closed by commit R236:ee34537ff55c: KMultiTabBar: Fix regression in conversion to new style connect() (authored by sars). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9884?vs=25

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Luigi Toscano
ltoscano reopened this revision. ltoscano added a comment. This revision is now accepted and ready to land. Give it some time. Right now Phabricator is only observing the repositories, not handling them, and this means that an update can land with some delay. REPOSITORY R236 KWidgetsAddons

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Kåre Särs
sars closed this revision. sars added a comment. For some reason this review was not closed automatically by the commit. Closing manually. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9884 To: sars, #frameworks, mlaurent

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Laurent Montel
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. indeed good catch REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9884 To: sars, #frameworks, mlaurent

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Kåre Särs
sars created this revision. sars added reviewers: Frameworks, mlaurent. Restricted Application added a project: Frameworks. sars requested review of this revision. REVISION SUMMARY The conversion to new style connect introduced a bug. The old connect properly used the base class signal while th