D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Randy Kron]

rkron added a comment.


  @davidedmundson Thanks for the commit!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

To: rkron, #frameworks, davidedmundson
Cc: dhaumann, ngraham, alexeymin, aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Dominik Haumann]

dhaumann added a comment.


  @davidedmundson If the associated bug is fixed, it should be closed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

To: rkron, #frameworks, davidedmundson
Cc: dhaumann, ngraham, alexeymin, aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:5eece6769f21: Fix one source of log spam referenced in 
Bug 388389 (Empty filename passed to… (authored by rkron, committed by 
davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9928?vs=25540=25699

REVISION DETAIL
  https://phabricator.kde.org/D9928

AFFECTED FILES
  src/plasma/svg.cpp

To: rkron, #frameworks, davidedmundson
Cc: ngraham, alexeymin, aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Randy Kron]

rkron added a comment.


  I'm new to phabricator and do not have commit access. Does someone need to 
commit this?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

To: rkron, #frameworks, davidedmundson
Cc: ngraham, alexeymin, aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

To: rkron, #frameworks, davidedmundson
Cc: alexeymin, aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Randy Kron]

rkron updated this revision to Diff 25540.
rkron added a comment.


  After reviewing the kio commit where similar changes were made, I changed 
QFile::exists to QFileInfo::exists as was done in kio and have updated my 
patch. I should have looked at kio before my first submission. Sorry.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9928?vs=25487=25540

REVISION DETAIL
  https://phabricator.kde.org/D9928

AFFECTED FILES
  src/plasma/svg.cpp

To: rkron, #frameworks, davidedmundson
Cc: alexeymin, aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Alexey Min]

alexeymin added a comment.


  There was a similar fix commited somewhere (don't remember, in KIO?) related 
to QFile in newer Qt complaining about empty filenames passed, so this is 
probably fine too...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

To: rkron, #frameworks, davidedmundson
Cc: alexeymin, aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Albert Astals Cid]

aacid added a comment.


  Wonder if QFile really should be giving a warning if the path is empty 
instead of just returning false to be honest, but i'll leave it to the plasma 
devs to decide if they want this or if we should try to convince Qt to be less 
spammy

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

To: rkron, #frameworks, davidedmundson
Cc: aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Anthony Fieroni]

anthonyfieroni added a reviewer: davidedmundson.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

To: rkron, #frameworks, davidedmundson
Cc: #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Randy Kron]

rkron created this revision.
rkron added a reviewer: Frameworks.
rkron added a project: Frameworks.
rkron requested review of this revision.

REVISION SUMMARY
  I found two places in plasma-framework svg.cpp (Plasma::Svg) that were 
triggering this message.
  
  path variable was not being checked for empty before passing to 
QFile::exists().
  
  This seems to be one source of the issue reported in Bug 388389 


TEST PLAN
  Found that kicker was triggering this message and also plasmashell tooltips.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

AFFECTED FILES
  src/plasma/svg.cpp

To: rkron, #frameworks
Cc: #frameworks