Re: KF5 Porting: Installing Icons

2014-07-25 Thread Alex Merry
On Friday 25 July 2014 02:52:09 Eike Hein wrote: On 07/24/2014 08:35 PM, Alex Merry wrote: As Jonathan said, yes, you are correct. And, yes, I should really write a porting script for that. Yay! That's the excuse I needed to avoid fixing Konvi's icon installs until your script is ready ;)

Re: KF5 Porting: Installing Icons

2014-07-24 Thread Alex Merry
On Wednesday 23 July 2014 18:08:42 David Narvaez wrote: Hi, The information at [0] seems to indicate I just need to worry about renaming files to match the new categories (btw, is there a script for that?) but what I get from CMake Warning (dev) at

Re: KF5 Porting: Installing Icons

2014-07-24 Thread Eike Hein
On 07/24/2014 08:35 PM, Alex Merry wrote: As Jonathan said, yes, you are correct. And, yes, I should really write a porting script for that. Yay! That's the excuse I needed to avoid fixing Konvi's icon installs until your script is ready ;) Alex Cheers, Eike

Re: KF5 Porting: Installing Icons

2014-07-24 Thread David Narvaez
On Thu, Jul 24, 2014 at 2:35 PM, Alex Merry alex.me...@kde.org wrote: As Jonathan said, yes, you are correct. And, yes, I should really write a porting script for that. Thanks for the confirmation, I just posted https://git.reviewboard.kde.org/r/119457/ David E. Narvaez

KF5 Porting: Installing Icons

2014-07-23 Thread David Narvaez
Hi, The information at [0] seems to indicate I just need to worry about renaming files to match the new categories (btw, is there a script for that?) but what I get from CMake Warning (dev) at /usr/share/ECM/modules/ECMInstallIcons.cmake:205 (message): ecm_install_icons() with no ICONS

Re: KF5 Porting: Installing Icons

2014-07-23 Thread Jonathan Riddell
On Wed, Jul 23, 2014 at 06:08:42PM -0400, David Narvaez wrote: This warning is for project developers. Use -Wno-dev to suppress it. is that I need to update to which seems to me like I need to explicitly list all icons in the dir, and Yes you are advised to use the new install function as

Re: KF5 Porting: Installing Icons

2014-07-23 Thread David Narvaez
On Wed, Jul 23, 2014 at 6:20 PM, Jonathan Riddell j...@jriddell.org wrote: # The given icons, whose names must match the pattern:: # # size-group-name.ext seems to indicate I need to rename all of the files to remove the theme from the prefix. Keep the theme name, preferably use hicolor

Re: KF5 Porting: Installing Icons

2014-07-23 Thread Jonathan Riddell
On Wed, Jul 23, 2014 at 06:23:32PM -0400, David Narvaez wrote: On Wed, Jul 23, 2014 at 6:20 PM, Jonathan Riddell j...@jriddell.org wrote: # The given icons, whose names must match the pattern:: # # size-group-name.ext seems to indicate I need to rename all of the files to remove the