Re: KIO: try to assign an icon to action submenus

2020-03-21 Thread David Faure
On dimanche 15 mars 2020 19:11:39 CET Chloe Kudryavtsev wrote: > So we need to be able to pass an icon inside of a ServiceList. > As mentioned, ServiceList is a QList. > QList is part of Qt and KServiceAction is part of KService. The usual solution for this is to replace ServiceList with struct S

Re: KIO: try to assign an icon to action submenus

2020-03-15 Thread Chloe Kudryavtsev
On 3/15/20 12:19 PM, David Faure wrote: > On vendredi 13 mars 2020 21:19:42 CET Chloe Kudryavtsev wrote: >> On 3/13/20 2:18 PM, David Faure wrote: >>> On mardi 3 mars 2020 18:29:47 CET Chloe Kudryavtsev wrote: Currently, action submenus (X-KDE-Submenu) have no icons. This patch makes it i

Re: KIO: try to assign an icon to action submenus

2020-03-15 Thread David Faure
On vendredi 13 mars 2020 21:19:42 CET Chloe Kudryavtsev wrote: > On 3/13/20 2:18 PM, David Faure wrote: > > On mardi 3 mars 2020 18:29:47 CET Chloe Kudryavtsev wrote: > >> Currently, action submenus (X-KDE-Submenu) have no icons. > >> This patch makes it inherit the icon of the first action. > > >

Re: KIO: try to assign an icon to action submenus

2020-03-13 Thread Chloe Kudryavtsev
On 3/13/20 2:18 PM, David Faure wrote: > On mardi 3 mars 2020 18:29:47 CET Chloe Kudryavtsev wrote: >> Currently, action submenus (X-KDE-Submenu) have no icons. >> This patch makes it inherit the icon of the first action. > > I wonder if this is always wanted? The icon for the first action might n

Re: KIO: try to assign an icon to action submenus

2020-03-13 Thread David Faure
On mardi 3 mars 2020 18:29:47 CET Chloe Kudryavtsev wrote: > Currently, action submenus (X-KDE-Submenu) have no icons. > This patch makes it inherit the icon of the first action. I wonder if this is always wanted? The icon for the first action might not be representative of what the other actions

Re: KIO: try to assign an icon to action submenus

2020-03-09 Thread Aleix Pol
Hi Chloe, I just submitted the patch on your behalf: https://phabricator.kde.org/D27950 Built it and seems to work. Hope this helps. Aleix On Sat, Mar 7, 2020 at 12:27 AM Chloe Kudryavtsev wrote: > > Currently, action submenus (X-KDE-Submenu) have no icons. > This patch makes it inherit the ico

KIO: try to assign an icon to action submenus

2020-03-06 Thread Chloe Kudryavtsev
Currently, action submenus (X-KDE-Submenu) have no icons. This patch makes it inherit the icon of the first action. There will always be at least one action, since empty submenus are eliminated earlier in the function. If the icon of the first action is empty, it will gracefully revert to old behav