El dissabte, 6 de juny de 2020, a les 19:00:59 CEST, David Faure va escriure:
> In order to switch kdeclarative to
> -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054700
> we need to port KRunProxy away from KRun, or to deprecate KRunProxy.
>
> AFAICS it exposes an object named KRun to
In order to switch kdeclarative to
-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054700
we need to port KRunProxy away from KRun, or to deprecate KRunProxy.
AFAICS it exposes an object named KRun to QML files, but searching for
qml files with KRun in them leads to no results:
https://lxr.kde.org
maxrd2 added a comment.
In https://phabricator.kde.org/D7676#143033, @broulik wrote:
> Well it is now "openService" calling "runApplication", that's inconsistent
isn't it
Yes, but it will start services that have Exec line though.
Should i just rename the method to "openApplicat
broulik added a comment.
Well it is now "openService" calling "runApplication", that's inconsistent
isn't it
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2, davidedmundson
Cc: broulik, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:a6d341f817c8: Added openService() method to KRunProxy
(authored by maxrd2, committed by davidedmundson).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7676
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
runproxy_openservice
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2, davidedmundson
Cc: broulik, #frameworks
maxrd2 updated this revision to Diff 19173.
maxrd2 marked an inline comment as done.
maxrd2 added a comment.
Removed service->isApplication() check, improved method description.
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7676?vs=19138&id=19173
BRA
maxrd2 added inline comments.
INLINE COMMENTS
> krunproxy.cpp:48
> KService::Ptr service = KService::serviceByDesktopPath(filePath);
> return KRun::runService(*service, QList(), nullptr) != 0;
> } else {
While I'm at it should i also change to runApplication() here?
> kru
maxrd2 added a dependent revision: D7648: Fix ksysguard not starting on
plasmoid click.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2, davidedmundson
Cc: broulik, #frameworks
maxrd2 added a comment.
Am not sure whether if( && service->isApplication()) is needed.
While I'm at it should i replace runService() with runApplication() inside
inside openUrl() method?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2,
maxrd2 updated this revision to Diff 19138.
maxrd2 added a comment.
Replaced runService() call with runApplication()
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7676?vs=19137&id=19138
BRANCH
runproxy_openservice
REVISION DETAIL
https://phabric
broulik added a comment.
Use `runApplication` for running applications which doesn't block until the
app has registered a DBus service
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2, davidedmundson
Cc: broulik, #frameworks
maxrd2 added a reviewer: davidedmundson.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2, davidedmundson
Cc: #frameworks
maxrd2 created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Added openService() method to KRunProxy so plasmoids can start applications
without needing to use openUrl() and "apps" d
14 matches
Mail list logo
