Re: New(ish) Framework review: kstatusnotifieritem

2023-08-18 Thread Albert Astals Cid
El dimecres, 16 d’agost de 2023, a les 13:35:44 (CEST), Nicolas Fella va 
escriure:
> Hi,
> 
> at the last meeting we decided to extract KStatusNotifierItem from
> KNotifications into a separate Framework.
> 
> Reasons are:
> 
> - They are rather distinct in scope/concept
> 
> - They negatively affect each other's dependencies
> 
> I've now created https://invent.kde.org/frameworks/kstatusnotifieritem
> and started porting users of KStatusNotifierItem to it.
> 
> Given that this is 100% pre-existing Frameworks code I don't think an
> in-depth "new framework review" is really appropriate, but if you have
> important and/or actionable points then we can of course discuss them.

It's missing a Messages.sh file

Cheers,
  Albert

> 
> Cheers
> 
> Nico






New(ish) Framework review: kstatusnotifieritem

2023-08-16 Thread Nicolas Fella

Hi,

at the last meeting we decided to extract KStatusNotifierItem from
KNotifications into a separate Framework.

Reasons are:

- They are rather distinct in scope/concept

- They negatively affect each other's dependencies

I've now created https://invent.kde.org/frameworks/kstatusnotifieritem
and started porting users of KStatusNotifierItem to it.

Given that this is 100% pre-existing Frameworks code I don't think an
in-depth "new framework review" is really appropriate, but if you have
important and/or actionable points then we can of course discuss them.

Cheers

Nico