Re: Pre-review CI

2018-07-30 Thread Ben Cooksley
ase I would prefer >> > separate jobs. Given review requests are prone to fail. >> >> Thing is, you don't care about the pre-review CI jobs as long as they >> are passing, but in case of fail, yes you might have to look at long >> log depending on where failure was, in fir

Re: Pre-review CI

2018-07-30 Thread Bhushan Shah
On Mon, Jul 30, 2018 at 11:50:48AM +0200, Friedrich W. H. Kossebau wrote: > More advantages with parallel builds: > * bigger projects, where building takes some time (krita, kdevelop, plasma-*, > etc) and where sometimes patches are reviewed almost in sync, parallel builds > mean quicker feedback

Re: Pre-review CI

2018-07-30 Thread Friedrich W. H. Kossebau
; > Thing is, you don't care about the pre-review CI jobs as long as they > are passing, but in case of fail, yes you might have to look at long > log depending on where failure was, in first platform or last one. So this is a use-case which should be optimized for, given it is

Re: Pre-review CI

2018-07-29 Thread Bhushan Shah
On Sun, Jul 29, 2018 at 05:00:19PM +0200, Friedrich W. H. Kossebau wrote: > 1 job means one huge build log to look at, or? In that case I would prefer > separate jobs. Given review requests are prone to fail. Thing is, you don't care about the pre-review CI jobs as long as they are p

Re: Pre-review CI

2018-07-29 Thread Friedrich W. H. Kossebau
Am Sonntag, 29. Juli 2018, 13:15:10 CEST schrieb Bhushan Shah: > Hello, > > So in previous email about staging repository I talked about pre-review > CI [1]. After some time, we finally have some code in ci-tooling which can > handle the pre-review CI for KDE repositories. And fo

Pre-review CI

2018-07-29 Thread Bhushan Shah
Hello, So in previous email about staging repository I talked about pre-review CI [1]. After some time, we finally have some code in ci-tooling which can handle the pre-review CI for KDE repositories. And for initial pilot run we want to enable it for frameworks repositories. We have several

D13819: dummy commit to test pre-review CI

2018-07-27 Thread Bhushan Shah
bshah removed a project: Frameworks. bshah removed a subscriber: kde-frameworks-devel. Restricted Application added a project: Frameworks. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, michaelh, ngraham, bruns, kde-frameworks-devel

D13819: dummy commit to test pre-review CI

2018-07-27 Thread Phabricator
Harbormaster failed remote builds in B1283: Diff 38634! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-27 Thread Jenkins-CI
jenkins-ci added a comment. Build is unstable Link to build: https://build.kde.org/job/Reviews/job/13819/3/ See console output for more information: https://build.kde.org/job/Reviews/job/13819/3/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 T

D13819: dummy commit to test pre-review CI

2018-07-27 Thread Bhushan Shah
bshah updated this revision to Diff 38634. bshah added a comment. - Revert "make it fail" - break test REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=38632&id=38634 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED

D13819: dummy commit to test pre-review CI

2018-07-27 Thread Phabricator
Harbormaster failed remote builds in B1282: Diff 38632! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-27 Thread Jenkins-CI
jenkins-ci added a comment. Build has FAILED Link to build: https://build.kde.org/job/Reviews/job/13819/2/ See console output for more information: https://build.kde.org/job/Reviews/job/13819/2/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To

D13819: dummy commit to test pre-review CI

2018-07-27 Thread Bhushan Shah
bshah updated this revision to Diff 38632. bshah added a comment. - make it fail REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=38631&id=38632 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt

D13819: dummy commit to test pre-review CI

2018-07-27 Thread Jenkins-CI
jenkins-ci added a comment. Build is green https://build.kde.org/job/Reviews/job/13819/1/ for more details. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-27 Thread Bhushan Shah
bshah updated this revision to Diff 38631. bshah added a comment. - change REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=38500&id=38631 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To: bs

D13819: dummy commit to test pre-review CI

2018-07-27 Thread Jenkins-CI
jenkins-ci added a comment. Build is green https://build.kde.org/job/Reviews/job/38500/4/ for more details. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-26 Thread Phabricator
Harbormaster failed remote builds in B1215: Diff 38500! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-26 Thread Bhushan Shah
bshah updated this revision to Diff 38500. bshah added a comment. - change REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=37574&id=38500 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To: bs

D13819: dummy commit to test pre-review CI

2018-07-11 Thread Jenkins-CI
jenkins-ci added a comment. Build is green https://build.kde.org/job/test/20/ for more details. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-11 Thread Bhushan Shah
bshah updated this revision to Diff 37574. bshah added a comment. - jhdkjfhdskj REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=37004&id=37574 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt T

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI
jenkins-ci added a comment. Build is green https://build.kde.org/job/test/19/ for more details. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 37004. bshah added a comment. - fix tests REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36992&id=37004 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To:

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI
jenkins-ci added a comment. Build is unstable Link to build: https://build.kde.org/job/test/18/ See console output for more information: https://build.kde.org/job/test/18/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci,

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Phabricator
Harbormaster failed remote builds in B521: Diff 36992! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 36992. bshah added a comment. - less fun, but this time try failing unit test REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36991&id=36992 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Phabricator
Harbormaster failed remote builds in B520: Diff 36991! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI
jenkins-ci added a comment. Build has FAILED Link to build: https://build.kde.org/job/test/17/ See console output for more information: https://build.kde.org/job/test/17/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci,

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 36991. bshah added a comment. - find qt5 fun, because that will make build fail REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36989&id=36991 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI
jenkins-ci added a comment. Build is green https://build.kde.org/job/test/16/ for more details. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 36989. bshah added a comment. - final change handover chnage REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36988&id=36989 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI
jenkins-ci added a comment. Build is green https://build.kde.org/job/test/15/ for more details. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Phabricator
Harbormaster failed remote builds in B517: Diff 36988! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI
jenkins-ci added a comment. Build has FAILED Link to build: https://build.kde.org/job/test/14/ See console output for more information: https://build.kde.org/job/test/14/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci,

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 36988. bshah added a comment. - enough derps REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36987&id=36988 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI
jenkins-ci added a comment. Build has FAILED Link to build: https://build.kde.org/job/test/13/ See console output for more information: https://build.kde.org/job/test/13/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci,

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Phabricator
Harbormaster failed remote builds in B516: Diff 36987! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 36987. bshah added a comment. - derp REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36986&id=36987 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To: bsha

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Phabricator
Harbormaster failed remote builds in B515: Diff 36986! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI
jenkins-ci added a comment. Build has FAILED Link to build: https://build.kde.org/job/test/12/ See console output for more information: https://build.kde.org/job/test/12/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci,

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 36986. bshah added a comment. - derp REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36985&id=36986 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To: bsha

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Phabricator
Harbormaster failed remote builds in B514: Diff 36985! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI
jenkins-ci added a comment. Build has FAILED Link to build: https://build.kde.org/job/test/11/ See console output for more information: https://build.kde.org/job/test/11/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci,

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
bshah updated this revision to Diff 36985. bshah added a comment. - edit 4, to check change handover works REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36982&id=36985 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTE

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah
lease ignore this, it is part of work to test the upcoming pre-review CI REPOSITORY R243 KArchive BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns