Re: Request for ktexteditor patch release

2020-05-16 Thread Nate Graham
If we're adding stuff to a 5.70 bugfix point release, 
https://cgit.kde.org/kio.git/commit/?id=8769b6360d87c1b688eac4d0ce97594351bad13c 
is another good candidate, which fixes a recent regression 
(https://bugs.kde.org/show_bug.cgi?id=421213).


Nate



On 5/15/20 4:42 AM, Friedrich W. H. Kossebau wrote:

Am Freitag, 15. Mai 2020, 12:03:08 CEST schrieb David Faure:

On vendredi 15 mai 2020 11:01:04 CEST Friedrich W. H. Kossebau wrote:

Hi,

I would like to ask for a 5.70 patch release for ktexteditor, with
972da14f486a83556e192d09bb18a2500728895a cherry-picked.

Not a crasher, but preventing the pickup of any global view setting
changes
after a kate/kdevelop session close & open cycle for existing document
views, which has been hit and reported by a few people already the last
days.


Thanks for the notification. Done:

ktexteditor v5.70.1
5e6ea19f95a36e21473c00a8d30cbea0f150a13f
c7b568e75c147161992f8875fe36fb46885bccddb63c22edaf81071583f4204c
sources/ktexteditor-5.70.1.tar.xz


Merci.


Please add a description of the bug in www/info/kde-frameworks-5.70.0.php
(or give me a patch if you can't push).


No checkout of the respective repo, so possibly fastest if I give you the raw
data here:
* KTextEditor global view setting changes ignored after session reopening
(Kate, KDevelop)
https://bugs.kde.org/show_bug.cgi?id=421375


Also, please make sure to write a unittest for this regression so we catch
it next time.


Yup.

Cheers
Friedrich




Re: Request for ktexteditor patch release

2020-05-16 Thread David Faure
On vendredi 15 mai 2020 15:37:00 CEST Nate Graham wrote:
> If we're adding stuff to a 5.70 bugfix point release,
> https://cgit.kde.org/kio.git/commit/?id=8769b6360d87c1b688eac4d0ce97594351ba
> d13c is another good candidate, which fixes a recent regression
> (https://bugs.kde.org/show_bug.cgi?id=421213).

Indeed. Sigh. 5.70.0 was really a bad release...

kio v5.70.1
9f64e5213460c258515705f07b97877fd34fe52a
b440f1a9408cd90ecc8a6bbeecbc4bde12365547bd8ca55c69619a2e659363b8  
sources/kio-5.70.1.tar.xz

+ info added to https://kde.org/info/kde-frameworks-5.70.0.php

Packagers, sorry for all this. Here's a changelog for the three 5.70.1 packages

### Plasma Framework

Fix crash due to disconnect of all signals in IconItem (bug 421170)

### KIO

CopyJob: Fix copying/moving files into a symlink to a directory (bug 421213)

### KTextEditor

KTextEditor global view setting changes ignored after session reopening (Kate, 
KDevelop) (bug 421375)


-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5





Re: Request for ktexteditor patch release

2020-05-15 Thread Friedrich W. H. Kossebau
Am Freitag, 15. Mai 2020, 12:03:08 CEST schrieb David Faure:
> On vendredi 15 mai 2020 11:01:04 CEST Friedrich W. H. Kossebau wrote:
> > Hi,
> > 
> > I would like to ask for a 5.70 patch release for ktexteditor, with
> > 972da14f486a83556e192d09bb18a2500728895a cherry-picked.
> > 
> > Not a crasher, but preventing the pickup of any global view setting
> > changes
> > after a kate/kdevelop session close & open cycle for existing document
> > views, which has been hit and reported by a few people already the last
> > days.
> 
> Thanks for the notification. Done:
> 
> ktexteditor v5.70.1
> 5e6ea19f95a36e21473c00a8d30cbea0f150a13f
> c7b568e75c147161992f8875fe36fb46885bccddb63c22edaf81071583f4204c 
> sources/ktexteditor-5.70.1.tar.xz

Merci.

> Please add a description of the bug in www/info/kde-frameworks-5.70.0.php
> (or give me a patch if you can't push).

No checkout of the respective repo, so possibly fastest if I give you the raw 
data here:
* KTextEditor global view setting changes ignored after session reopening 
(Kate, KDevelop)
https://bugs.kde.org/show_bug.cgi?id=421375

> Also, please make sure to write a unittest for this regression so we catch
> it next time.

Yup. 

Cheers
Friedrich




Re: Request for ktexteditor patch release

2020-05-15 Thread David Faure
On vendredi 15 mai 2020 11:01:04 CEST Friedrich W. H. Kossebau wrote:
> Hi,
> 
> I would like to ask for a 5.70 patch release for ktexteditor, with
> 972da14f486a83556e192d09bb18a2500728895a cherry-picked.
> 
> Not a crasher, but preventing the pickup of any global view setting changes
> after a kate/kdevelop session close & open cycle for existing document
> views, which has been hit and reported by a few people already the last
> days.

Thanks for the notification. Done:

ktexteditor v5.70.1
5e6ea19f95a36e21473c00a8d30cbea0f150a13f
c7b568e75c147161992f8875fe36fb46885bccddb63c22edaf81071583f4204c  
sources/ktexteditor-5.70.1.tar.xz

Please add a description of the bug in www/info/kde-frameworks-5.70.0.php (or 
give me a patch if you can't push).

Also, please make sure to write a unittest for this regression so we catch it 
next time.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5





Request for ktexteditor patch release

2020-05-15 Thread Friedrich W. H. Kossebau
Hi,

I would like to ask for a 5.70 patch release for ktexteditor, with 
972da14f486a83556e192d09bb18a2500728895a cherry-picked.

Not a crasher, but preventing the pickup of any global view setting changes 
after a kate/kdevelop session close & open cycle for existing document views, 
which has been hit and reported by a few people already the last days.

Cheers
Friedrich