Re: Review Request/New Framework: KF5::SyntaxHighlighting

2016-10-02 Thread Volker Krause
On Saturday 01 October 2016 21:28:54 Dominik Haumann wrote: > On Fri, Sep 30, 2016 at 10:08 AM, David Faure wrote: > > On samedi 10 septembre 2016 17:47:00 CEST Volker Krause wrote: > >> please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > >> becoming a

Re: Review Request/New Framework: KF5::SyntaxHighlighting

2016-10-01 Thread David Faure
On samedi 1 octobre 2016 21:28:54 CEST Dominik Haumann wrote: > @David: Can you take care of not releasing with KF 5.27? Yes, ok - reverted the .yaml file again. > Btw, say we do not release the framework with KF 5.27, can KTextEditor > already depend on in it master starting next week or so for

Re: Review Request/New Framework: KF5::SyntaxHighlighting

2016-10-01 Thread Dominik Haumann
On Fri, Sep 30, 2016 at 10:08 AM, David Faure wrote: > On samedi 10 septembre 2016 17:47:00 CEST Volker Krause wrote: >> please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for >> becoming a framework :) > > Looks good. I found a few things though. > [...] Christoph

Re: Review Request/New Framework: KF5::SyntaxHighlighting

2016-09-30 Thread Scarlett Clark
On Fri, Sep 30, 2016 at 10:32 AM, Volker Krause wrote: > Thanks! > > On Friday 30 September 2016 10:08:27 David Faure wrote: > > On samedi 10 septembre 2016 17:47:00 CEST Volker Krause wrote: > > > Hi, > > > > > > please review KF5::SyntaxHighlighting (syntax-highlighting in

Re: Review Request/New Framework: KF5::SyntaxHighlighting

2016-09-30 Thread Volker Krause
Thanks! On Friday 30 September 2016 10:08:27 David Faure wrote: > On samedi 10 septembre 2016 17:47:00 CEST Volker Krause wrote: > > Hi, > > > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > > becoming a framework :) > > Looks good. I found a few things though. > > I

Re: Review Request/New Framework: KF5::SyntaxHighlighting

2016-09-30 Thread David Faure
On samedi 10 septembre 2016 17:47:00 CEST Volker Krause wrote: > Hi, > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > becoming a framework :) Looks good. I found a few things though. I see that a Jenkins job exists, but it's missing from this view

Re: Review Request/New Framework: KF5::SyntaxHighlighting

2016-09-11 Thread Volker Krause
On Sunday 11 September 2016 05:33:29 Michael Palimaka wrote: > On 11/09/16 01:47, Volker Krause wrote: > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > > becoming a framework :) > > Thanks a lot for working on this. > > I noticed that

Re: Review Request/New Framework: KF5::SyntaxHighlighting

2016-09-10 Thread Michael Palimaka
Hi, On 11/09/16 01:47, Volker Krause wrote: > Hi, > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > becoming a framework :) Thanks a lot for working on this. I noticed that KF5SyntaxHighlightingConfig.cmake.in searches for Qt5Widgets, but that doesn't seem to used

Re: Review Request/New Framework: KF5::SyntaxHighlighting

2016-09-10 Thread Christoph Cullmann
Hi, will take a look at the API that is exposed for this first version, too. Thanks already for stepping up to "framework" your pet project, this might avoid that we end up with "just one more" highlighting implementation and perhaps even QtCreator can somewhen use (aka copy) this one to have

Re: Review Request/New Framework: KF5::SyntaxHighlighting

2016-09-10 Thread Dominik Haumann
Hi Volker, thanks for this initiative! On Sat, Sep 10, 2016 at 5:47 PM, Volker Krause wrote: > Hi, > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > becoming a framework :) > > This is a tier1/functional version of the Kate syntax highlighting engine.

Review Request/New Framework: KF5::SyntaxHighlighting

2016-09-10 Thread Volker Krause
Hi, please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for becoming a framework :) This is a tier1/functional version of the Kate syntax highlighting engine. It's not tied to a particular output format or editor engine, the interface is basically just passing in a line of text