Re: Review Request: KF5 - Q_OS_* not defined

2012-09-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/#review19247 --- Ship it! Please commit, the current stuff (Q_OS in

Re: Review Request: KF5 - Q_OS_* not defined

2012-08-06 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/ --- (Updated Aug. 5, 2012, 10:25 p.m.) Review request for KDE Frameworks and

Re: Review Request: KF5 - Q_OS_* not defined

2012-08-06 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/ --- (Updated Aug. 5, 2012, 10:28 p.m.) Review request for KDE Frameworks and

Re: Review Request: KF5 - Q_OS_* not defined

2012-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/#review16878 --- Ship it! Ah, yes, this is a porting error. KDE4 cmake stuff