Re: Review Request: KF5 - Q_OS_* not defined
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/#review19247 --- Ship it! Please commit, the current stuff (Q_OS in CMakeLists.txt) is just wrong :) - David Faure On Aug. 5, 2012, 10:28 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/ --- (Updated Aug. 5, 2012, 10:28 p.m.) Review request for KDE Frameworks and kdewin. Description --- Q_OS_WIN Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE. Diffs - kde3support/KDE3SupportMacros.cmake a4f44e2 kdecore/CMakeLists.txt e5cbd19 kded/CMakeLists.txt fb204e8 kdeui/CMakeLists.txt 7849b52 kdeui/KDEUIMacros.cmake d5c20d9 kinit/CMakeLists.txt 3c283a6 tier1/kidletime/src/CMakeLists.txt 973d623 tier1/kwindowsystem/src/CMakeLists.txt 96cb3dd Diff: http://git.reviewboard.kde.org/r/105868/diff/ Testing --- Got undefined references before the fix. Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request: KF5 - Q_OS_* not defined
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/ --- (Updated Aug. 5, 2012, 10:25 p.m.) Review request for KDE Frameworks and kdewin. Changes --- Updated patch to fix other occurrences. Description --- Q_OS_WIN Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE. Diffs (updated) - kde3support/KDE3SupportMacros.cmake a4f44e2 kdecore/CMakeLists.txt e5cbd19 kded/CMakeLists.txt fb204e8 kdeui/CMakeLists.txt 7849b52 kdeui/KDEUIMacros.cmake d5c20d9 kinit/CMakeLists.txt 3c283a6 tier1/kidletime/src/CMakeLists.txt 973d623 tier1/kwindowsystem/src/CMakeLists.txt 96cb3dd Diff: http://git.reviewboard.kde.org/r/105868/diff/ Testing --- Got undefined references before the fix. Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request: KF5 - Q_OS_* not defined
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/ --- (Updated Aug. 5, 2012, 10:28 p.m.) Review request for KDE Frameworks and kdewin. Changes --- Oops ... last one had something wrong. Description --- Q_OS_WIN Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE. Diffs (updated) - kde3support/KDE3SupportMacros.cmake a4f44e2 kdecore/CMakeLists.txt e5cbd19 kded/CMakeLists.txt fb204e8 kdeui/CMakeLists.txt 7849b52 kdeui/KDEUIMacros.cmake d5c20d9 kinit/CMakeLists.txt 3c283a6 tier1/kidletime/src/CMakeLists.txt 973d623 tier1/kwindowsystem/src/CMakeLists.txt 96cb3dd Diff: http://git.reviewboard.kde.org/r/105868/diff/ Testing --- Got undefined references before the fix. Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request: KF5 - Q_OS_* not defined
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/#review16878 --- Ship it! Ah, yes, this is a porting error. KDE4 cmake stuff used to define Q_WS_* cmake variables, but nothing does that in KF5. I trust you that WIN32 and APPLE are right here, no experience with that. However this should be fixed across the board, not just in kidletime: kdecore/CMakeLists.txt:if (NOT Q_OS_X11)// LOL that's a good one :-) kded/CMakeLists.txt:if (Q_OS_MAC) kded/CMakeLists.txt:endif (Q_OS_MAC) kdeui/CMakeLists.txt:if (Q_OS_MAC AND MAC_USE_OSXKEYCHAIN) kdeui/CMakeLists.txt:else(Q_OS_MAC AND MAC_USE_OSXKEYCHAIN) kdeui/CMakeLists.txt:else(Q_OS_MAC AND MAC_USE_OSXKEYCHAIN) kdeui/CMakeLists.txt:endif(Q_OS_MAC AND MAC_USE_OSXKEYCHAIN) kdeui/CMakeLists.txt:if (Q_OS_MAC) kdeui/CMakeLists.txt:endif (Q_OS_MAC) kdeui/CMakeLists.txt:if (Q_OS_WIN) kdeui/CMakeLists.txt:endif (Q_OS_WIN) kdeui/CMakeLists.txt:if(Q_OS_MAC) kdeui/CMakeLists.txt:endif(Q_OS_MAC) kdeui/CMakeLists.txt:if (Q_OS_MAC) kdeui/CMakeLists.txt:elseif (Q_OS_WIN) kdeui/CMakeLists.txt:else(Q_OS_WIN) kdeui/CMakeLists.txt:endif (Q_OS_MAC) kdeui/CMakeLists.txt:if (Q_OS_MAC) kdeui/CMakeLists.txt:endif (Q_OS_MAC) kinit/CMakeLists.txt:if (Q_OS_MAC) kinit/CMakeLists.txt:else (Q_OS_MAC) kinit/CMakeLists.txt:endif (Q_OS_MAC) tier1/kidletime/src/CMakeLists.txt:elseif (Q_OS_MAC) tier1/kidletime/src/CMakeLists.txt:elseif (Q_OS_WIN) tier1/kwindowsystem/src/CMakeLists.txt:if (Q_OS_MAC) tier1/kwindowsystem/src/CMakeLists.txt:if (Q_OS_WIN) - David Faure On Aug. 4, 2012, 9:57 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/ --- (Updated Aug. 4, 2012, 9:57 p.m.) Review request for KDE Frameworks and kdewin. Description --- Q_OS_WIN Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE. Diffs - tier1/kidletime/src/CMakeLists.txt 973d623 Diff: http://git.reviewboard.kde.org/r/105868/diff/ Testing --- Got undefined references before the fix. Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
