---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105867/#review16877
---
Thanks for looking at the Windows build of KDE Frameworks! Very appreciated.
Just one issue in this patch.
libinqt5/src/qtemporarydir.cpp
http://git.reviewboard.kde.org/r/105867/#comment13212
This is keeping a pointer to a temporary buffer (the QString returned by
toNativeSeparators) which gets deleted at the end of this line. So it will
probably crash.
Put the result of the call in a QString first, then call utf6() on it.
- David Faure
On Aug. 4, 2012, 9:47 p.m., Andrius da Costa Ribas wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105867/
---
(Updated Aug. 4, 2012, 9:47 p.m.)
Review request for KDE Frameworks and kdewin.
Description
---
General fixes for Windows build. Replaced some references to Qt5 libraries
into the Qt4 equivalent ones.
Diffs
-
libinqt5/src/CMakeLists.txt 99f75e5
libinqt5/src/qstandardpaths.cpp f97a861
libinqt5/src/qstandardpaths_win.cpp 478e614
libinqt5/src/qtemporarydir.cpp 6121a83
Diff: http://git.reviewboard.kde.org/r/105867/diff/
Testing
---
Build OK with MSVC. No further tests because of other issues with other parts
of KF5 build.
Thanks,
Andrius da Costa Ribas
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
