Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/ --- (Updated June 20, 2013, 8:16 a.m.) Review request for KDE Frameworks.

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/ --- (Updated June 20, 2013, 10:22 a.m.) Review request for KDE Frameworks.

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/#review34747 --- Ship it! Ship It! - Kevin Ottens On June 20, 2013, 10:22

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/ --- (Updated June 20, 2013, 10:35 a.m.) Status -- This change has been

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/#review34748 --- This review has been submitted with commit

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-19 Thread Kevin Ottens
On June 18, 2013, 2:06 p.m., Kevin Ottens wrote: kio/tests/jobtest.cpp, line 264 http://git.reviewboard.kde.org/r/111081/diff/1/?file=164106#file164106line264 Do we agree that the goal is that both uiDelegate() and interactionInterface() will return 0 if you link only kiocore?

Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/ --- Review request for KDE Frameworks. Description --- KIO::Job: more

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-18 Thread David Faure
On June 18, 2013, 2:06 p.m., Kevin Ottens wrote: kio/kio/job.cpp, line 209 http://git.reviewboard.kde.org/r/111081/diff/1/?file=164098#file164098line209 Interesting... So not having the uiDelegate() but the interactionInterface() qualify as interactive... Not sure if that could