Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-11-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Nov. 4, 2013, 6:45 a.m.) Status -- This change has been

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-11-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review42924 --- This review has been submitted with commit

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-10-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review42333 --- Ship it!

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-10-23 Thread Martin Gräßlin
On Sept. 23, 2013, 12:07 p.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras?

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-10-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Oct. 24, 2013, 7:19 a.m.) Review request for KDE Frameworks.

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-10-21 Thread Kevin Ottens
On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras?

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-10-09 Thread Kevin Ottens
On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras?

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-30 Thread Martin Gräßlin
On Sept. 23, 2013, 12:07 p.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras?

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-29 Thread David Faure
On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras?

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-29 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review41013 --- The API seems too tied to the way XKB does things. I don't

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review40510 --- Tested the patch in my tree, works for caps lock too. Now it

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-23 Thread Martin Gräßlin
On Sept. 23, 2013, 12:07 p.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras? Then I

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-23 Thread Kevin Ottens
On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras?

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 3, 2013, 8:18 a.m.) Review request for KDE Frameworks.

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review39239 --- Ship it! Just tested it, Caps Lock works fine. The only

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-03 Thread Martin Gräßlin
On Sept. 3, 2013, 11:09 a.m., David Faure wrote: Just tested it, Caps Lock works fine. The only thing I couldn't figure out in the test app is the mouse button checkboxes at the bottom. mouse buttons work for me. Though I did not get First and Second X Button to work. - Martin