Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Nov. 4, 2013, 6:45 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - tier1/kguiaddons/CMakeLists.txt e4578aa tier1/kguiaddons/src/lib/CMakeLists.txt 4b9e4cd tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review42924 --- This review has been submitted with commit ff6150cab8b276c8fec5c3297ef83406fa9171d1 by Martin Gräßlin to branch frameworks. - Commit Hook On Oct. 24, 2013, 5:19 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Oct. 24, 2013, 5:19 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - tier1/kguiaddons/CMakeLists.txt e4578aa tier1/kguiaddons/src/lib/CMakeLists.txt 4b9e4cd tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review42333 --- Ship it! tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp http://git.reviewboard.kde.org/r/112443/#comment30787 Maybe add a comment that this is the same a QX11Info::display(), but we don't want to link to QtX11Extras here. tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp http://git.reviewboard.kde.org/r/112443/#comment30786 Using qApp would work too, after all the display() method already relies on a QGuiApp being used rather than a QCoreApp. - David Faure On Oct. 24, 2013, 5:19 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Oct. 24, 2013, 5:19 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - tier1/kguiaddons/CMakeLists.txt e4578aa tier1/kguiaddons/src/lib/CMakeLists.txt 4b9e4cd tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
On Sept. 23, 2013, 12:07 p.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras? Martin Gräßlin wrote: Then I would suggest to move this class to KWindowSystem for the moment. For the module KX11Extras I still need some code changes first (for some reason netwm is using KWindowSystem - it's wrong IMHO and needs fixing) Kevin Ottens wrote: Well, if you remember it was my first choice to put KModifierKeyInfo in KWindowSystem, but you pushed back. :-) I'm ok if you move it there then, looking forward to the patches. ;-) David Faure wrote: You know, if the dependency on QX11Extras is only for QX11Info::display(), that's really easy to write by hand in kmodifierkeyinfo_x11.cpp (see the 5 lines in QX11Info::display). Although I suspect after porting to XCB it would rather be about QX11Info::connection(), same thing though (accessible via QPlatformNativeInterface). QX11Info mostly exists for Qt4 source compat and for convenience, it's not mandatory to go through it. I'm not convinced about this going to KWindowSystem. An application developer who would want to display a Caps Lock indicator in the statusbar of his wordprocessor (say kile, which does exactly this) would first look at Qt, then notice you can't query it for the status of CapsLock, and would then look at kguiaddons and find it. But why would they look into KWindowSystem for this? This has nothing to do with window management. It's a key handling feature, complementing what's in QtGui. I certainly expect it to be implemented on Windows and/or Mac at some point in the future, it definitely makes sense there too (unlike, say, NETWM). Martin Gräßlin wrote: Ok, I can see how to get away from QX11Extras, but Kevin also complained about XLib and XCB. And I do not see how I can interact with X11 without using either of those two. So either I'm allowed to use X-specific code in this module or the code cannot go into this module. Kevin Ottens wrote: XCB is less of an issue if that's an optional dependency. Kevin Ottens wrote: Dropped some of the issues to reflect my previous comment. I just tried to get rid of the QX11Extras dependency. But I'm failing trying to access the QPA. I'm getting a compile error that qplatformnativeinterface.h cannot be found. Any ideas? - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review40510 --- On Sept. 4, 2013, 8:37 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 4, 2013, 8:37 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - tier1/kguiaddons/CMakeLists.txt 3124c4d tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Oct. 24, 2013, 7:19 a.m.) Review request for KDE Frameworks. Changes --- Removed the QX11Extras dependency. Please verify that the approach for getting access to the QPA is correct. Repository: kdelibs Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs (updated) - tier1/kguiaddons/CMakeLists.txt e4578aa tier1/kguiaddons/src/lib/CMakeLists.txt 4b9e4cd tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras? Martin Gräßlin wrote: Then I would suggest to move this class to KWindowSystem for the moment. For the module KX11Extras I still need some code changes first (for some reason netwm is using KWindowSystem - it's wrong IMHO and needs fixing) Kevin Ottens wrote: Well, if you remember it was my first choice to put KModifierKeyInfo in KWindowSystem, but you pushed back. :-) I'm ok if you move it there then, looking forward to the patches. ;-) David Faure wrote: You know, if the dependency on QX11Extras is only for QX11Info::display(), that's really easy to write by hand in kmodifierkeyinfo_x11.cpp (see the 5 lines in QX11Info::display). Although I suspect after porting to XCB it would rather be about QX11Info::connection(), same thing though (accessible via QPlatformNativeInterface). QX11Info mostly exists for Qt4 source compat and for convenience, it's not mandatory to go through it. I'm not convinced about this going to KWindowSystem. An application developer who would want to display a Caps Lock indicator in the statusbar of his wordprocessor (say kile, which does exactly this) would first look at Qt, then notice you can't query it for the status of CapsLock, and would then look at kguiaddons and find it. But why would they look into KWindowSystem for this? This has nothing to do with window management. It's a key handling feature, complementing what's in QtGui. I certainly expect it to be implemented on Windows and/or Mac at some point in the future, it definitely makes sense there too (unlike, say, NETWM). Martin Gräßlin wrote: Ok, I can see how to get away from QX11Extras, but Kevin also complained about XLib and XCB. And I do not see how I can interact with X11 without using either of those two. So either I'm allowed to use X-specific code in this module or the code cannot go into this module. Kevin Ottens wrote: XCB is less of an issue if that's an optional dependency. Dropped some of the issues to reflect my previous comment. - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review40510 --- On Sept. 4, 2013, 6:37 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 4, 2013, 6:37 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - tier1/kguiaddons/CMakeLists.txt 3124c4d tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras? Martin Gräßlin wrote: Then I would suggest to move this class to KWindowSystem for the moment. For the module KX11Extras I still need some code changes first (for some reason netwm is using KWindowSystem - it's wrong IMHO and needs fixing) Kevin Ottens wrote: Well, if you remember it was my first choice to put KModifierKeyInfo in KWindowSystem, but you pushed back. :-) I'm ok if you move it there then, looking forward to the patches. ;-) David Faure wrote: You know, if the dependency on QX11Extras is only for QX11Info::display(), that's really easy to write by hand in kmodifierkeyinfo_x11.cpp (see the 5 lines in QX11Info::display). Although I suspect after porting to XCB it would rather be about QX11Info::connection(), same thing though (accessible via QPlatformNativeInterface). QX11Info mostly exists for Qt4 source compat and for convenience, it's not mandatory to go through it. I'm not convinced about this going to KWindowSystem. An application developer who would want to display a Caps Lock indicator in the statusbar of his wordprocessor (say kile, which does exactly this) would first look at Qt, then notice you can't query it for the status of CapsLock, and would then look at kguiaddons and find it. But why would they look into KWindowSystem for this? This has nothing to do with window management. It's a key handling feature, complementing what's in QtGui. I certainly expect it to be implemented on Windows and/or Mac at some point in the future, it definitely makes sense there too (unlike, say, NETWM). Martin Gräßlin wrote: Ok, I can see how to get away from QX11Extras, but Kevin also complained about XLib and XCB. And I do not see how I can interact with X11 without using either of those two. So either I'm allowed to use X-specific code in this module or the code cannot go into this module. XCB is less of an issue if that's an optional dependency. - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review40510 --- On Sept. 4, 2013, 6:37 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 4, 2013, 6:37 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - tier1/kguiaddons/CMakeLists.txt 3124c4d tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
On Sept. 23, 2013, 12:07 p.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras? Martin Gräßlin wrote: Then I would suggest to move this class to KWindowSystem for the moment. For the module KX11Extras I still need some code changes first (for some reason netwm is using KWindowSystem - it's wrong IMHO and needs fixing) Kevin Ottens wrote: Well, if you remember it was my first choice to put KModifierKeyInfo in KWindowSystem, but you pushed back. :-) I'm ok if you move it there then, looking forward to the patches. ;-) David Faure wrote: You know, if the dependency on QX11Extras is only for QX11Info::display(), that's really easy to write by hand in kmodifierkeyinfo_x11.cpp (see the 5 lines in QX11Info::display). Although I suspect after porting to XCB it would rather be about QX11Info::connection(), same thing though (accessible via QPlatformNativeInterface). QX11Info mostly exists for Qt4 source compat and for convenience, it's not mandatory to go through it. I'm not convinced about this going to KWindowSystem. An application developer who would want to display a Caps Lock indicator in the statusbar of his wordprocessor (say kile, which does exactly this) would first look at Qt, then notice you can't query it for the status of CapsLock, and would then look at kguiaddons and find it. But why would they look into KWindowSystem for this? This has nothing to do with window management. It's a key handling feature, complementing what's in QtGui. I certainly expect it to be implemented on Windows and/or Mac at some point in the future, it definitely makes sense there too (unlike, say, NETWM). Ok, I can see how to get away from QX11Extras, but Kevin also complained about XLib and XCB. And I do not see how I can interact with X11 without using either of those two. So either I'm allowed to use X-specific code in this module or the code cannot go into this module. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review40510 --- On Sept. 4, 2013, 8:37 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 4, 2013, 8:37 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - tier1/kguiaddons/CMakeLists.txt 3124c4d tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras? Martin Gräßlin wrote: Then I would suggest to move this class to KWindowSystem for the moment. For the module KX11Extras I still need some code changes first (for some reason netwm is using KWindowSystem - it's wrong IMHO and needs fixing) Kevin Ottens wrote: Well, if you remember it was my first choice to put KModifierKeyInfo in KWindowSystem, but you pushed back. :-) I'm ok if you move it there then, looking forward to the patches. ;-) You know, if the dependency on QX11Extras is only for QX11Info::display(), that's really easy to write by hand in kmodifierkeyinfo_x11.cpp (see the 5 lines in QX11Info::display). Although I suspect after porting to XCB it would rather be about QX11Info::connection(), same thing though (accessible via QPlatformNativeInterface). QX11Info mostly exists for Qt4 source compat and for convenience, it's not mandatory to go through it. I'm not convinced about this going to KWindowSystem. An application developer who would want to display a Caps Lock indicator in the statusbar of his wordprocessor (say kile, which does exactly this) would first look at Qt, then notice you can't query it for the status of CapsLock, and would then look at kguiaddons and find it. But why would they look into KWindowSystem for this? This has nothing to do with window management. It's a key handling feature, complementing what's in QtGui. I certainly expect it to be implemented on Windows and/or Mac at some point in the future, it definitely makes sense there too (unlike, say, NETWM). - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review40510 --- On Sept. 4, 2013, 6:37 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 4, 2013, 6:37 a.m.) Review request for KDE Frameworks. Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - tier1/kguiaddons/CMakeLists.txt 3124c4d tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review41013 --- The API seems too tied to the way XKB does things. I don't think the concept of latched vs locked state would map cleanly to other platforms. What's the use case for distinguishing between them? - Nicolás Alvarez On Sept. 4, 2013, 6:37 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 4, 2013, 6:37 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - tier1/kguiaddons/CMakeLists.txt 3124c4d tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review40510 --- Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras? tier1/kguiaddons/CMakeLists.txt http://git.reviewboard.kde.org/r/112443/#comment29830 This dependency is unwanted in kguiaddons. tier1/kguiaddons/CMakeLists.txt http://git.reviewboard.kde.org/r/112443/#comment29831 ditto. tier1/kguiaddons/CMakeLists.txt http://git.reviewboard.kde.org/r/112443/#comment29832 ditto. - Kevin Ottens On Sept. 4, 2013, 6:37 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 4, 2013, 6:37 a.m.) Review request for KDE Frameworks. Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - tier1/kguiaddons/CMakeLists.txt 3124c4d tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
On Sept. 23, 2013, 12:07 p.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras? Then I would suggest to move this class to KWindowSystem for the moment. For the module KX11Extras I still need some code changes first (for some reason netwm is using KWindowSystem - it's wrong IMHO and needs fixing) - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review40510 --- On Sept. 4, 2013, 8:37 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 4, 2013, 8:37 a.m.) Review request for KDE Frameworks. Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - tier1/kguiaddons/CMakeLists.txt 3124c4d tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras? Martin Gräßlin wrote: Then I would suggest to move this class to KWindowSystem for the moment. For the module KX11Extras I still need some code changes first (for some reason netwm is using KWindowSystem - it's wrong IMHO and needs fixing) Well, if you remember it was my first choice to put KModifierKeyInfo in KWindowSystem, but you pushed back. :-) I'm ok if you move it there then, looking forward to the patches. ;-) - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review40510 --- On Sept. 4, 2013, 6:37 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 4, 2013, 6:37 a.m.) Review request for KDE Frameworks. Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - tier1/kguiaddons/CMakeLists.txt 3124c4d tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 3, 2013, 8:18 a.m.) Review request for KDE Frameworks. Changes --- implemented approach of defining the events - structs copied from xkb.h as found in 3rdparty copy of qtbase. Note that this doesn't matter for copyright as xcb event structures are auto-generated from xml description. Summary (updated) - Native event filter porting for KModifierKeyInfoProvider Description (updated) --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs (updated) - CMakeLists.txt 48f607b staging/kguiaddons/CMakeLists.txt c2e5735 staging/kguiaddons/src/lib/CMakeLists.txt dc6aafa staging/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e staging/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing (updated) --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review39239 --- Ship it! Just tested it, Caps Lock works fine. The only thing I couldn't figure out in the test app is the mouse button checkboxes at the bottom. - David Faure On Sept. 3, 2013, 6:18 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 3, 2013, 6:18 a.m.) Review request for KDE Frameworks. Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - CMakeLists.txt 48f607b staging/kguiaddons/CMakeLists.txt c2e5735 staging/kguiaddons/src/lib/CMakeLists.txt dc6aafa staging/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e staging/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
On Sept. 3, 2013, 11:09 a.m., David Faure wrote: Just tested it, Caps Lock works fine. The only thing I couldn't figure out in the test app is the mouse button checkboxes at the bottom. mouse buttons work for me. Though I did not get First and Second X Button to work. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review39239 --- On Sept. 3, 2013, 8:18 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 3, 2013, 8:18 a.m.) Review request for KDE Frameworks. Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - CMakeLists.txt 48f607b staging/kguiaddons/CMakeLists.txt c2e5735 staging/kguiaddons/src/lib/CMakeLists.txt dc6aafa staging/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e staging/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
