Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/#review39878 --- This review has been submitted with commit bcefbe5d0fe90154cec

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/ --- (Updated Sept. 12, 2013, 1:19 p.m.) Status -- This change has been ma

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/ --- (Updated Sept. 10, 2013, 5:39 p.m.) Review request for KDE Frameworks and

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/ --- (Updated Sept. 10, 2013, 4:52 p.m.) Review request for KDE Frameworks and

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-10 Thread Aleix Pol Gonzalez
> On Sept. 10, 2013, 6:46 a.m., David Faure wrote: > > staging/kdoctools/src/meinproc.cpp, line 112 > > > > > > isn't it better to not define the option, so that the user gets > > "unknown option --cache"? > >

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/#review39743 --- staging/kdoctools/src/meinproc.cpp

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/#review39690 --- Looks good to me. About whether it's worth keeping the option:

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/ --- (Updated Sept. 9, 2013, 2:50 p.m.) Review request for KDE Frameworks and A

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/#review39558 --- Patch missing. - David Faure On Sept. 5, 2013, 5:23 p.m., Al

Review Request 112545: Unify both meinproc5 binaries

2013-09-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/ --- Review request for KDE Frameworks and Albert Astals Cid. Description -