Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/#review40233 --- This review has been submitted with commit

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/ --- (Updated Sept. 17, 2013, 3:49 p.m.) Status -- This change has been

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/#review39935 --- Ship it! ... after fixing the last two small issues.

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/#review39866 --- General approach looks good.

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-12 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/ --- (Updated Sept. 12, 2013, 7:07 p.m.) Review request for KDE Frameworks and

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-12 Thread Sebastian Kügler
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote: staging/kservice/src/services/kplugininfo.cpp, line 61 http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61 I think that two variables (hidden and _hidden) so similar are confusing. Sebastian Kügler

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-11 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/#review39793 --- staging/kservice/src/services/kplugininfo.cpp

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-11 Thread Sebastian Kügler
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote: staging/kservice/src/services/kplugininfo.cpp, line 61 http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61 I think that two variables (hidden and _hidden) so similar are confusing. Hm, I think it's

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-11 Thread David Gil Oliva
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote: staging/kservice/src/services/kplugininfo.cpp, line 61 http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61 I think that two variables (hidden and _hidden) so similar are confusing. Sebastian Kügler

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-11 Thread Sebastian Kügler
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote: staging/kservice/src/services/kplugininfo.cpp, line 61 http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61 I think that two variables (hidden and _hidden) so similar are confusing. Sebastian Kügler

Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/ --- Review request for KDE Frameworks and David Faure. Description ---