---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112660/#review40233
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112660/
---
(Updated Sept. 17, 2013, 3:49 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112660/#review39935
---
Ship it!
... after fixing the last two small issues.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112660/#review39866
---
General approach looks good.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112660/
---
(Updated Sept. 12, 2013, 7:07 p.m.)
Review request for KDE Frameworks and
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote:
staging/kservice/src/services/kplugininfo.cpp, line 61
http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61
I think that two variables (hidden and _hidden) so similar are
confusing.
Sebastian Kügler
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112660/#review39793
---
staging/kservice/src/services/kplugininfo.cpp
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote:
staging/kservice/src/services/kplugininfo.cpp, line 61
http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61
I think that two variables (hidden and _hidden) so similar are
confusing.
Hm, I think it's
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote:
staging/kservice/src/services/kplugininfo.cpp, line 61
http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61
I think that two variables (hidden and _hidden) so similar are
confusing.
Sebastian Kügler
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote:
staging/kservice/src/services/kplugininfo.cpp, line 61
http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61
I think that two variables (hidden and _hidden) so similar are
confusing.
Sebastian Kügler
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112660/
---
Review request for KDE Frameworks and David Faure.
Description
---
11 matches
Mail list logo