Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/#review40234 --- This review has been submitted with commit 96f363e4f7f8b6655df

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/ --- (Updated Sept. 17, 2013, 3:49 p.m.) Status -- This change has been ma

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/#review40192 --- Ship it! staging/kservice/src/services/ktraderparsetree.cpp <

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/ --- (Updated Sept. 14, 2013, 6:17 p.m.) Review request for KDE Frameworks and

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-14 Thread Sebastian Kügler
> On Sept. 12, 2013, 7:39 a.m., David Faure wrote: > > staging/kservice/src/services/ktraderparsetree.cpp, line 715 > > > > > > kdelibs coding style -> no space inside (), '{' on the same line. > > > > fo

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/#review39864 --- staging/kservice/src/services/ktraderparsetree.cpp

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/#review39859 --- 2 issues I'd like to get advise for inline. staging/kservice/

Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/ --- Review request for KDE Frameworks and David Faure. Description --- Th