Re: Review Request 112730: Make knewstuff build standalone

2013-09-29 Thread David Faure
> On Sept. 17, 2013, 7:30 a.m., David Faure wrote: > > knewstuff/CMakeLists.txt, line 9 > > > > > > Does this really build when building all of kdelibs in one go? I > > thought we determined that find_package of kf

Re: Review Request 112730: Make knewstuff build standalone

2013-09-23 Thread Jeremy Whiting
> On Sept. 17, 2013, 1:30 a.m., David Faure wrote: > > knewstuff/CMakeLists.txt, line 9 > > > > > > Does this really build when building all of kdelibs in one go? I > > thought we determined that find_package of kf

Re: Review Request 112730: Make knewstuff build standalone

2013-09-17 Thread Chusslove Illich
> On Sept. 17, 2013, 10:05 a.m., Chusslove Illich wrote: > > knewstuff/src/downloaddialog.cpp, line 35 > > > > > > Technically it is possible to mix translation frameworks, but I see no > > point > > to that.

Re: Review Request 112730: Make knewstuff build standalone

2013-09-17 Thread David Faure
> On Sept. 17, 2013, 8:05 a.m., Chusslove Illich wrote: > > knewstuff/src/downloaddialog.cpp, line 35 > > > > > > Technically it is possible to mix translation frameworks, but I see no > > point > > to that. C

Re: Review Request 112730: Make knewstuff build standalone

2013-09-17 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/#review40194 --- knewstuff/src/downloaddialog.cpp

Re: Review Request 112730: Make knewstuff build standalone

2013-09-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/#review40193 --- knewstuff/CMakeLists.txt

Re: Review Request 112730: Make knewstuff build standalone

2013-09-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/ --- (Updated Sept. 17, 2013, 7:29 a.m.) Review request for KDE Frameworks, Alb

Review Request 112730: Make knewstuff build standalone

2013-09-14 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/ --- Review request for KDE Frameworks and David Faure. Description --- Th