Re: Review Request 112730: add CMake changes to knewstuff

2013-10-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/#review41686 --- knewstuff/CMakeLists.txt

Re: Review Request 112730: add CMake changes to knewstuff

2013-10-14 Thread Jeremy Whiting
On Oct. 12, 2013, 10:43 a.m., David Faure wrote: knewstuff/KNewStuffConfig.cmake.in, line 4 http://git.reviewboard.kde.org/r/112730/diff/3/?file=200166#file200166line4 why is kjs listed as a dependency here but not in the cmakelists.txt? Ah, the Config.cmake.in I copied from had

Re: Review Request 112730: add CMake changes to knewstuff

2013-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/ --- (Updated Oct. 14, 2013, 10:56 p.m.) Status -- This change has been

Re: Review Request 112730: add CMake changes to knewstuff

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/#review41760 --- This review has been submitted with commit

Re: Review Request 112730: add CMake changes to knewstuff

2013-10-09 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/ --- (Updated Oct. 9, 2013, 2:24 p.m.) Review request for KDE Frameworks,

Re: Review Request 112730: add CMake changes to knewstuff

2013-10-01 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/ --- (Updated Oct. 1, 2013, 7:01 p.m.) Review request for KDE Frameworks,