---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/
---
(Updated Sept. 20, 2013, 1:26 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/
---
Review request for KDE Frameworks and Aurélien Gâteau.
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/#review40352
---
Looks good overall, but I found a few minor issues.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/#review40350
---
Maybe you should add a note in KDE5Porting.html?
- Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/#review40351
---
Maybe you should add a note in KDE5Porting.html?
- Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/
---
(Updated Sept. 19, 2013, 3:25 p.m.)
Review request for KDE Frameworks and
On Sept. 19, 2013, 2:27 p.m., Aurélien Gâteau wrote:
tier1/kwidgetsaddons/tests/CMakeLists.txt, line 6
http://git.reviewboard.kde.org/r/112823/diff/1/?file=190546#file190546line6
In KDE4 days programs marked as test had a KDESRCDIR define set which
pointed to
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/
---
(Updated Sept. 19, 2013, 3:07 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/#review40361
---
Ship it!
Patch does not apply there (complains about
