Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

2013-09-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112957/ --- (Updated Sept. 26, 2013, 4:13 p.m.) Status -- This change has been ma

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

2013-09-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112957/#review40882 --- This review has been submitted with commit 7a3114156a514287416

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

2013-09-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112957/#review40873 --- Ship it! Looks good, send it when it's split as stephen suggue

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

2013-09-26 Thread Stephen Kelly
> On Sept. 26, 2013, 11:56 a.m., Stephen Kelly wrote: > > You seem to be doing 3 different things here. Please make sure to do each > > one in a separate commit. > > Vishesh Handa wrote: > Alright. I'll split it into 3 different commits. Do you want 3 different > reviews as well? Or will t

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

2013-09-26 Thread Vishesh Handa
> On Sept. 26, 2013, 11:56 a.m., Stephen Kelly wrote: > > You seem to be doing 3 different things here. Please make sure to do each > > one in a separate commit. Alright. I'll split it into 3 different commits. Do you want 3 different reviews as well? Or will this one do? - Vishesh ---

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

2013-09-26 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112957/#review40856 --- You seem to be doing 3 different things here. Please make sure

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

2013-09-26 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112957/ --- (Updated Sept. 26, 2013, 11:11 a.m.) Review request for KDE Frameworks.

Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

2013-09-26 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112957/ --- Review request for KDE Frameworks. Description --- Removed usage of K