Re: Review Request 113247: Port KCompletion away from KStandardAction

2013-10-23 Thread David Edmundson
On Oct. 15, 2013, 1:40 p.m., Kevin Ottens wrote: tier2/kcompletion/src/klineedit.cpp, line 1174 http://git.reviewboard.kde.org/r/113247/diff/1/?file=201273#file201273line1174 Couldn't it use QKeySequence::DeleteCompleteLine instead? or is KStandardShortcut::Clear different? They

Re: Review Request 113247: Port KCompletion away from KStandardAction

2013-10-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113247/#review42220 --- This review has been submitted with commit

Re: Review Request 113247: Port KCompletion away from KStandardAction

2013-10-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113247/ --- (Updated Oct. 23, 2013, 2:16 p.m.) Status -- This change has been

Re: Review Request 113247: Port KCompletion away from KStandardAction

2013-10-15 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113247/#review41775 --- tier2/kcompletion/src/klineedit.cpp

Review Request 113247: Port KCompletion away from KStandardAction

2013-10-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113247/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Review Request 113247: Port KCompletion away from KStandardAction

2013-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113247/#review41750 --- Ship it! Good catch David! - Aleix Pol Gonzalez On Oct.