Re: Review Request 113376: KDirWatch: don't check for symlinks on Windows.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113376/#review42259 --- This review has been submitted with commit c363b940745620873e2c2fde4a84d8f9fd1792f2 by Nicolás Alvarez to branch frameworks. - Commit Hook On Oct. 21, 2013, 11:46 p.m., Nicolás Alvarez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113376/ --- (Updated Oct. 21, 2013, 11:46 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- KDirWatch: don't check for symlinks on Windows. Windows doesn't have symbolic links, at least not in the same way as Unix, so it doesn't have functions like lstat. Diffs - tier1/kcoreaddons/src/lib/io/kdirwatch.cpp 3468529605526c0f02e6350a90d65105b19c4708 Diff: http://git.reviewboard.kde.org/r/113376/diff/ Testing --- KDirWatch tests still pass on Linux. Still doesn't compile on Windows, but getting closer. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113376: KDirWatch: don't check for symlinks on Windows.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113376/ --- (Updated Oct. 23, 2013, 11:47 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- KDirWatch: don't check for symlinks on Windows. Windows doesn't have symbolic links, at least not in the same way as Unix, so it doesn't have functions like lstat. Diffs - tier1/kcoreaddons/src/lib/io/kdirwatch.cpp 3468529605526c0f02e6350a90d65105b19c4708 Diff: http://git.reviewboard.kde.org/r/113376/diff/ Testing --- KDirWatch tests still pass on Linux. Still doesn't compile on Windows, but getting closer. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113376: KDirWatch: don't check for symlinks on Windows.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113376/#review42172 --- Ship it! Inspecting the code, you don't seem to have changed the logic on Unix systems, so it looks good to me. - Alex Merry On Oct. 21, 2013, 11:46 p.m., Nicolás Alvarez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113376/ --- (Updated Oct. 21, 2013, 11:46 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- KDirWatch: don't check for symlinks on Windows. Windows doesn't have symbolic links, at least not in the same way as Unix, so it doesn't have functions like lstat. Diffs - tier1/kcoreaddons/src/lib/io/kdirwatch.cpp 3468529605526c0f02e6350a90d65105b19c4708 Diff: http://git.reviewboard.kde.org/r/113376/diff/ Testing --- KDirWatch tests still pass on Linux. Still doesn't compile on Windows, but getting closer. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113376: KDirWatch: don't check for symlinks on Windows.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113376/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- KDirWatch: don't check for symlinks on Windows. Windows doesn't have symbolic links, at least not in the same way as Unix, so it doesn't have functions like lstat. Diffs - tier1/kcoreaddons/src/lib/io/kdirwatch.cpp 3468529605526c0f02e6350a90d65105b19c4708 Diff: http://git.reviewboard.kde.org/r/113376/diff/ Testing --- KDirWatch tests still pass on Linux. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
