Re: Review Request 113972: Add some autotests for KMediaPlayer

2013-11-20 Thread Alex Merry

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113972/
---

(Updated Nov. 21, 2013, midnight)


Review request for KDE Frameworks.


Changes
---

Use QCOMPARE instead of QVERIFY, for better error messages.


Repository: kdelibs


Description
---

Add some autotests for KMediaPlayer


Diffs (updated)
-

  staging/kmediaplayer/CMakeLists.txt c9f301ae961a0fd7f4ad71f1a7cec766493f3d14 
  staging/kmediaplayer/autotests/CMakeLists.txt PRE-CREATION 
  staging/kmediaplayer/autotests/playertest.cpp PRE-CREATION 
  staging/kmediaplayer/autotests/testplayer.h PRE-CREATION 
  staging/kmediaplayer/autotests/testview.h PRE-CREATION 
  staging/kmediaplayer/autotests/viewtest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113972/diff/


Testing
---

Builds, new tests run and pass.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 113972: Add some autotests for KMediaPlayer

2013-11-20 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113972/#review44084
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 21, 2013, midnight, Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113972/
 ---
 
 (Updated Nov. 21, 2013, midnight)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 Add some autotests for KMediaPlayer
 
 
 Diffs
 -
 
   staging/kmediaplayer/CMakeLists.txt 
 c9f301ae961a0fd7f4ad71f1a7cec766493f3d14 
   staging/kmediaplayer/autotests/CMakeLists.txt PRE-CREATION 
   staging/kmediaplayer/autotests/playertest.cpp PRE-CREATION 
   staging/kmediaplayer/autotests/testplayer.h PRE-CREATION 
   staging/kmediaplayer/autotests/testview.h PRE-CREATION 
   staging/kmediaplayer/autotests/viewtest.cpp PRE-CREATION 
 
 Diff: http://git.reviewboard.kde.org/r/113972/diff/
 
 
 Testing
 ---
 
 Builds, new tests run and pass.
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel