Re: Review Request 114272: Fix broken connect for signal finished in kcmultidialog

2013-12-05 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114272/#review45171
---


This review has been submitted with commit 
b7a67bab6269f8cbd61c0fa293baa659b98184f7 by Martin Gräßlin to branch frameworks.

- Commit Hook


On Dec. 3, 2013, 2:34 p.m., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/114272/
 ---
 
 (Updated Dec. 3, 2013, 2:34 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 see title
 
 
 Diffs
 -
 
   tier3/kcmutils/src/kcmultidialog.cpp 5326b69 
 
 Diff: http://git.reviewboard.kde.org/r/114272/diff/
 
 
 Testing
 ---
 
 Without change: warning when starting kcmshell5
 With change: no warning when starting kcmshell5
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 114272: Fix broken connect for signal finished in kcmultidialog

2013-12-05 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114272/
---

(Updated Dec. 5, 2013, 10:35 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

see title


Diffs
-

  tier3/kcmutils/src/kcmultidialog.cpp 5326b69 

Diff: http://git.reviewboard.kde.org/r/114272/diff/


Testing
---

Without change: warning when starting kcmshell5
With change: no warning when starting kcmshell5


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 114272: Fix broken connect for signal finished in kcmultidialog

2013-12-04 Thread Kevin Ottens

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114272/#review45143
---

Ship it!


Ship It!

- Kevin Ottens


On Dec. 3, 2013, 2:34 p.m., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/114272/
 ---
 
 (Updated Dec. 3, 2013, 2:34 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 see title
 
 
 Diffs
 -
 
   tier3/kcmutils/src/kcmultidialog.cpp 5326b69 
 
 Diff: http://git.reviewboard.kde.org/r/114272/diff/
 
 
 Testing
 ---
 
 Without change: warning when starting kcmshell5
 With change: no warning when starting kcmshell5
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 114272: Fix broken connect for signal finished in kcmultidialog

2013-12-03 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114272/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

see title


Diffs
-

  tier3/kcmutils/src/kcmultidialog.cpp 5326b69 

Diff: http://git.reviewboard.kde.org/r/114272/diff/


Testing
---

Without change: warning when starting kcmshell5
With change: no warning when starting kcmshell5


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 114272: Fix broken connect for signal finished in kcmultidialog

2013-12-03 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114272/#review45042
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Dec. 3, 2013, 2:34 p.m., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/114272/
 ---
 
 (Updated Dec. 3, 2013, 2:34 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 see title
 
 
 Diffs
 -
 
   tier3/kcmutils/src/kcmultidialog.cpp 5326b69 
 
 Diff: http://git.reviewboard.kde.org/r/114272/diff/
 
 
 Testing
 ---
 
 Without change: warning when starting kcmshell5
 With change: no warning when starting kcmshell5
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel