Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS = KDE_ENABLE_EXCEPTIONS

2013-12-17 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/ --- (Updated Dec. 17, 2013, 10:42 a.m.) Status -- This change has been

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS = KDE_ENABLE_EXCEPTIONS

2013-12-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/#review45854 --- This review has been submitted with commit

Review Request 114502: KDE4_ENABLE_EXCEPTIONS = KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/ --- Review request for Build System and KDE Frameworks. Repository: kdelibs

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS = KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/#review45801 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Dec.

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS = KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/#review45812 --- Ship it! Ship It! - Kevin Ottens On Dec. 16, 2013, 5:10

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS = KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/#review45830 --- This gets rid of the annoying ignoring unknown option

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS = KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Aurélien Gâteau
On Dec. 16, 2013, 11:05 p.m., Nicolás Alvarez wrote: This gets rid of the annoying ignoring unknown option '-fexceptions' I kept getting when compiling threadweaver with MSVC. That's a bit surprising: flags should be the same. I suspect you have not applied the matching ECM patch from