---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114885/
---
(Updated Jan. 7, 2014, 3:22 p.m.)
Review request for Build System, KDE
On Jan. 7, 2014, 3:36 p.m., Stephen Kelly wrote:
kde-modules/KDECompilerSettings.cmake, line 34
https://git.reviewboard.kde.org/r/114885/diff/1/?file=233187#file233187line34
add_compiler_export_flags() should not be used at all.
On Jan. 7, 2014, 3:36 p.m., Stephen Kelly wrote:
kde-modules/KDECompilerSettings.cmake, line 25
https://git.reviewboard.kde.org/r/114885/diff/1/?file=233187#file233187line25
Setting CMAKE_CXX_FLAGS is not 'modern cmake'. Prefer to use
add_compile_options instead.
On Jan. 7, 2014, 3:36 p.m., Stephen Kelly wrote:
kde-modules/KDECompilerSettings.cmake, line 25
https://git.reviewboard.kde.org/r/114885/diff/1/?file=233187#file233187line25
Setting CMAKE_CXX_FLAGS is not 'modern cmake'. Prefer to use
add_compile_options instead.
On Jan. 7, 2014, 3:36 p.m., Stephen Kelly wrote:
kde-modules/KDECompilerSettings.cmake, line 25
https://git.reviewboard.kde.org/r/114885/diff/1/?file=233187#file233187line25
Setting CMAKE_CXX_FLAGS is not 'modern cmake'. Prefer to use
add_compile_options instead.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114885/
---
(Updated Jan. 7, 2014, 4:30 p.m.)
Review request for Build System, KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114885/#review46996
---
Ship it!
Nice, this also fixes some inconsistencies between
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114885/
---
(Updated Jan. 7, 2014, 7:13 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114885/#review46997
---
This review has been submitted with commit
